fix!: Backup - set IAM conditions conditionally #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikmueller
requested review from
isaurabhuttam,
imrannayer and
a team
as code owners
IAM conditions can only be used to restrict access to DatabaseInstances or BackupRuns. They can't be used to restrict access to Database resources. The export workflow uses the `googleapis.sqladmin.v1.databases.list` call to gather all database names. This call fails with the error code 403: unauthorized when the IAM conditions are set. > The client is not authorized to make this request.
dominikmueller
force-pushed
the
fix-iam-conditions
branch
from
30abff9
to
c599e9b
Compare
dominikmueller
changed the title
|
/gcbrun |
imrannayer
changed the title
imrannayer
approved these changes
Jul 15, 2024
imrannayer
changed the title
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
imrannayer
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAM conditions can only be used to restrict access to DatabaseInstances or BackupRuns. They can't be used to restrict access to Database resources.
The export workflow uses the
googleapis.sqladmin.v1.databases.listcall to gather all database names.This call fails with the error code 403: unauthorized when the IAM conditions are set.
Supported Resource Type Values in IAM Conditions: docs