Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement. Update tests to exercise examples #76

Merged
merged 12 commits into from
Dec 16, 2019
Merged

Enhancement. Update tests to exercise examples #76

merged 12 commits into from
Dec 16, 2019

Conversation

SKozlovsky
Copy link
Contributor

@SKozlovsky SKozlovsky commented Dec 2, 2019 •
edited
Loading

@SKozlovsky SKozlovsky force-pushed the feature/update-tests-to-exercise-examples branch 2 times, most recently from 81b9ae9 to e880e42 Compare December 2, 2019 16:34
@SKozlovsky SKozlovsky changed the title [IN PROGRESS] Update tests to exercise examples Enhancement. Update tests to exercise examples Dec 2, 2019
@aaron-lane aaron-lane self-assigned this Dec 2, 2019
@aaron-lane aaron-lane added the enhancement New feature or request label Dec 2, 2019
@SKozlovsky SKozlovsky requested a review from aaron-lane December 5, 2019 10:45
aaron-lane
aaron-lane suggested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SKozlovsky!

examples/mysql-ha/main.tf Show resolved Hide resolved
examples/mysql-private/main.tf Show resolved Hide resolved
examples/postgresql-ha/main.tf Show resolved Hide resolved
modules/mysql/outputs.tf Outdated Show resolved Hide resolved
modules/postgresql/outputs.tf Outdated Show resolved Hide resolved
modules/safer_mysql/outputs.tf Outdated Show resolved Hide resolved
test/fixtures/mysql-private/variables.tf Outdated Show resolved Hide resolved
test/fixtures/mysql-public/variables.tf Outdated Show resolved Hide resolved
test/fixtures/postgres-public/variables.tf Outdated Show resolved Hide resolved
@SKozlovsky
Issue terraform-google-modules#73
53eb84b 
- separate mysql and postgres examples
- add some tests
- provide examples for HA clusters
- kitchen tests examples
@SKozlovsky
Requested changes and merged master
8fc5fe6
@SKozlovsky SKozlovsky force-pushed the feature/update-tests-to-exercise-examples branch from 6da8e69 to 8fc5fe6 Compare December 11, 2019 15:46
@aaron-lane aaron-lane force-pushed the feature/update-tests-to-exercise-examples branch from 25ecc39 to 36b667d Compare December 16, 2019 20:13
@aaron-lane aaron-lane merged commit 0529839 into terraform-google-modules:master Dec 16, 2019
aaron-lane added a commit that referenced this pull request Dec 16, 2019
@aaron-lane
Add #76 to CHANGELOG
417fc61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

Assignees

@aaron-lane aaron-lane

@SKozlovsky SKozlovsky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tests to exercise examples
3 participants
@SKozlovsky @aaron-lane @omazin