Rename output 'instance_address' to 'instance_ip_address' in all submodules #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omazin
force-pushed
the
rename-output
branch
from
f161be7 to
63a727d
Compare
omazin
requested review from
aaron-lane and
namusyaka
and removed request for
aaron-lane
aaron-lane
changed the title
aaron-lane
previously approved these changes
Dec 16, 2019
aaron-lane
suggested changes
Dec 16, 2019
There was a problem hiding this comment.
Thanks @omazin!
Can you please apply those changes to the mysql and safer_mysql submodules as well, and update the CHANGELOG accordingly?
…d safer_mysql submodules. Fix typo.
omazin
changed the title
aaron-lane
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Please review the PR after #80 is merged.