Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update TPG version constraints to allow 4.0 #215

Merged
merged 6 commits into from
Nov 24, 2021
Merged

feat: update TPG version constraints to allow 4.0 #215

merged 6 commits into from
Nov 24, 2021

Conversation

jackwhelpton
Copy link
Contributor

  • breaking changes in 4.0 are k8s-specific

This was referenced Nov 23, 2021
Closed
Closed
@comment-bot-dev
Copy link

comment-bot-dev commented Nov 23, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@jackwhelpton
Copy link
Contributor Author

Looks like there is an automated request that does the same thing, although not quite effectively... I'm merging those commits now to see if I can fix them up.

@jackwhelpton
Merge branch 'bot-update-tpg4' of https://github.com/terraform-google…
1d64cfe 
…-modules/terraform-google-vm into feature/provider-upgrade

# Conflicts:
#	autogen/versions.tf.tmpl
#	modules/compute_disk_snapshot/versions.tf
#	modules/compute_instance/versions.tf
#	modules/instance_template/versions.tf
#	modules/mig/versions.tf
#	modules/mig_with_percent/versions.tf
#	modules/preemptible_and_regular_instance_templates/versions.tf
#	modules/umig/versions.tf
@jackwhelpton
Copy link
Contributor Author

jackwhelpton commented Nov 23, 2021 •
edited
Loading

It appears that google_kms_crypto_key no longer exports a self_link attribute, trying to track down when that changed and what the correct resolution is.

It appears that the old self_link attribute was of the form projects/{projectId}/locations/{location}/keyRings/{keyRingName}/cryptoKeys/{cryptoKeyName} (http://man.hubwiz.com/docset/Terraform.docset/Contents/Resources/Documents/docs/providers/google/r/google_kms_crypto_key.html) whilst the new id attribute is of the form {{key_ring}}/cryptoKeys/{{name}} (https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/kms_crypto_key#attributes-reference)

bharathkkb
bharathkkb approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @jackwhelpton

@bharathkkb bharathkkb changed the title Loosens Google provider constraints feat: update TPG version constraints to allow 4.0 Nov 24, 2021
@bharathkkb bharathkkb mentioned this pull request Nov 24, 2021
Closed
@bharathkkb bharathkkb merged commit af7347b into terraform-google-modules:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackwhelpton @comment-bot-dev @bharathkkb @cloud-foundation-bot