Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update TPG version constraints to allow 4.0 #65

Merged
merged 5 commits into from
Jan 11, 2022
Merged

feat: update TPG version constraints to allow 4.0 #65

merged 5 commits into from
Jan 11, 2022

Conversation

cloud-foundation-bot
Copy link
Collaborator

This PR was auto generated, please review for accuracy before merging

@comment-bot-dev
Copy link

comment-bot-dev commented Nov 17, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@tpdownes tpdownes mentioned this pull request Jan 5, 2022
Merged
@morgante morgante mentioned this pull request Jan 10, 2022
Closed
@aweberlopes
Copy link
Contributor

Will have a look on it.

@aweberlopes
Copy link
Contributor

@morgante check the other pull request that covers that

@aweberlopes @bharathkkb
fix tpg 4.0 update (#70)
7e3b6d2 
* added changes for provider

* added changes

* Update examples/bq-exfil-demo/versions.tf

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
aweberlopes
aweberlopes reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@aweberlopes aweberlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

bharathkkb
bharathkkb approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some modules were bumped to ~> 4.0, suggestions below reverts those to continue supporting 3.x

modules/bridge_service_perimeter/versions.tf Outdated Show resolved Hide resolved
modules/regular_service_perimeter/versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit 8f7a51c into master Jan 11, 2022
@bharathkkb bharathkkb deleted the bot-update-tpg4 branch January 11, 2022 19:09
@release-please release-please bot mentioned this pull request Jan 11, 2022
Merged
@release-please release-please bot mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweberlopes aweberlopes aweberlopes left review comments

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cloud-foundation-bot @comment-bot-dev @aweberlopes @bharathkkb @morgante