-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for forks #50
Conversation
Adds a topic that describes how to fork a repo to update it. Content that is now reused is moved to `inc`lude files. Change title of topic about updating an older module to `Porting` to distinguish from new topic.
Fix link to reference architecture template
Adds a topic that describes how to fork a repo to update it. Content that is now reused is moved to `inc`lude files. Change title of topic about updating an older module to `Porting` to distinguish from new topic.
…entation into fork-support
- Recombine creating and updating a module as before - Update dev setup and migrate-module to support forks - Remove unused include files
@daniel-butler-irl: Recombined the contributing topic to support both new modules and updating modules. Removed the step when forking to Copy the main branch only. You can see the internal version at https://pages.github.ibm.com/allen-dean/tim-docs/#/contribute-module |
Great, looks good now. One thing I saw is, we now have a doc gap. Not sure if it goes in this PR. Now we accept forks it means external contributors can contribute. These users will not have access to trigger the pipeline. The Open pull request section needs to be updated to state, if you are a member of github-collaborators you can trigger the pipeline. Then the next part we need to figure out is for external contributors maybe ask to notify |
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
Closed in favor of #52 because this PR keeps dismissing reviews. |
Description
See a comment in the internal issue #3813 for a link to where this draft is published internally.
Info about contributing a new module still uses a clone. Let me know if the workflow will instead be that the contributor forks the module that we create.
inc
lude files.Porting
to distinguish from new topic.Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers