Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ci dependencies #701

Merged
merged 7 commits into from
Jul 26, 2024
Merged

chore(deps): update ci dependencies #701

merged 7 commits into from
Jul 26, 2024

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Jul 24, 2024

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J requested a review from toddgiguere as a code owner July 24, 2024 10:26
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Screenshot 2024-07-24 at 1 27 25 PM
The changes are update in place.

@Aashiq-J
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member

@Aashiq-J Why are we ignoring this now?? The consistency check is to ensure the module is idempotent, and if it fails we need to know why, and not just ignore it

@Aashiq-J
Copy link
Member Author

@ocofaigh ,This is similar to this provider bug,
created a new provider issue for this.
This error is causing all PR and continuous pipelines to fail for this module.

@Aashiq-J
Copy link
Member Author

/run pipeline

@toddgiguere
Copy link
Contributor

@Aashiq-J @ocofaigh I think we are going to have to add these ignores this way, at least until the provider fixes this idempotent issue. When looking at testwrapper, it only supports identification of updates (and ignoring those updates) at the resource level, not the attribute level.

@ocofaigh ocofaigh merged commit a06bb7a into main Jul 26, 2024
2 checks passed
@ocofaigh ocofaigh deleted the ci-updates branch July 26, 2024 12:53
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants