-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose CheckClusterIngressHealthy to the pr_test.go #869
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
|
@@ -221,6 +221,7 @@ func TestRunRoksPattern(t *testing.T) { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocofaigh @toddgiguere The PostApplyHook
never executes because TestRunRoksPattern
are skipped when enableSchematicsTests is True. Where should we add the hook because other test methods like TestRunVSIPattern, TestRunVpcPattern are also getting skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The landing zone tests executes in schematics and post apply hook is yet to be supported in schematics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking this to deep dive today to decide whether we add a support for post apply hook in schematics or is there any other way to approach it?
Description
This PR exposes CheckClusterIngressHealthy to the pr_test.go to know the ingress state of the cluster.
https://github.ibm.com/GoldenEye/issues/issues/10545
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Addition of getClusterIngress method to expose the ingress state of the cluster
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers