Skip to content

Commit

Permalink
feat: removed support for classic access as this is now a deprecated …
Browse files Browse the repository at this point in the history
…feature<br>- input variable `classic_access` has been removed (#68)

Co-authored-by: Aatreyee Mukherjee <aatreyeemukherjee@Aatreyees-MacBook-Pro.local>
  • Loading branch information
aatreyee2506 and Aatreyee Mukherjee authored Nov 19, 2024
1 parent 45de647 commit b2cd50e
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 16 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ No resources.
|------|-------------|------|---------|:--------:|
| <a name="input_address_prefixes"></a> [address\_prefixes](#input\_address\_prefixes) | List of Prefixes for the vpc | <pre>list(object({<br/> name = string<br/> location = string<br/> ip_range = string<br/> }))</pre> | `[]` | no |
| <a name="input_auto_assign_address_prefix"></a> [auto\_assign\_address\_prefix](#input\_auto\_assign\_address\_prefix) | Set to true to create a default address prefix automatically for each zone in the VPC. | `bool` | `true` | no |
| <a name="input_classic_access"></a> [classic\_access](#input\_classic\_access) | Classic Access to the VPC | `bool` | `false` | no |
| <a name="input_clean_default_sg_acl"></a> [clean\_default\_sg\_acl](#input\_clean\_default\_sg\_acl) | Remove all rules from the default VPC security group and VPC ACL (less permissive) | `bool` | `false` | no |
| <a name="input_create_gateway"></a> [create\_gateway](#input\_create\_gateway) | True to create new Gateway | `bool` | `false` | no |
| <a name="input_create_vpc"></a> [create\_vpc](#input\_create\_vpc) | True to create new VPC. False if VPC is already existing and subnets or address prefixies are to be added | `bool` | `true` | no |
Expand Down
1 change: 0 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ module "vpc" {
create_vpc = var.create_vpc
vpc_name = var.vpc_name
resource_group_id = var.resource_group_id
classic_access = var.classic_access
default_address_prefix = var.auto_assign_address_prefix ? "auto" : "manual"
default_network_acl_name = var.default_network_acl_name
default_security_group_name = var.default_security_group_name
Expand Down
2 changes: 0 additions & 2 deletions modules/vpc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ module "vpc" {
create_vpc = var.create_vpc
vpc_name = var.vpc_name
resource_group_id = data.ibm_resource_group.resource_group.id
classic_access = var.classic_access
default_address_prefix = var.default_address_prefix
default_network_acl_name = var.default_network_acl_name
default_security_group_name = var.default_security_group_name
Expand Down Expand Up @@ -59,7 +58,6 @@ No modules.
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_address_prefixes"></a> [address\_prefixes](#input\_address\_prefixes) | List of Prefixes for the vpc | <pre>list(object({<br/> name = string<br/> location = string<br/> ip_range = string<br/> }))</pre> | `[]` | no |
| <a name="input_classic_access"></a> [classic\_access](#input\_classic\_access) | Classic Access to the VPC | `bool` | `false` | no |
| <a name="input_clean_default_sg_acl"></a> [clean\_default\_sg\_acl](#input\_clean\_default\_sg\_acl) | Remove all rules from the default VPC security group and VPC ACL (less permissive) | `bool` | `false` | no |
| <a name="input_create_gateway"></a> [create\_gateway](#input\_create\_gateway) | True to create new Gateway | `bool` | `false` | no |
| <a name="input_create_vpc"></a> [create\_vpc](#input\_create\_vpc) | True to create new VPC. False if VPC is already existing and subnets or address prefixies are to be added | `bool` | `true` | no |
Expand Down
1 change: 0 additions & 1 deletion modules/vpc/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ resource "ibm_is_vpc" "vpc" {
count = var.create_vpc ? 1 : 0
name = var.vpc_name
resource_group = var.resource_group_id
classic_access = var.classic_access
address_prefix_management = var.default_address_prefix
default_network_acl_name = var.default_network_acl_name
default_security_group_name = var.default_security_group_name
Expand Down
5 changes: 0 additions & 5 deletions modules/vpc/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ variable "resource_group_id" {
default = null
}

variable "classic_access" {
description = "Classic Access to the VPC"
type = bool
default = false
}

variable "default_address_prefix" {
description = "Default address prefix creation method"
Expand Down
6 changes: 0 additions & 6 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,6 @@ variable "resource_group_id" {
default = null
}

variable "classic_access" {
description = "Classic Access to the VPC"
type = bool
default = false
}

variable "auto_assign_address_prefix" {
description = "Set to true to create a default address prefix automatically for each zone in the VPC."
type = bool
Expand Down

0 comments on commit b2cd50e

Please sign in to comment.