Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appsync: Remove invalid regexp rules #462

Merged
merged 1 commit into from
Mar 18, 2023
Merged

appsync: Remove invalid regexp rules #462

merged 1 commit into from
Mar 18, 2023

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Mar 18, 2023 •
edited
Loading

Fixes #461

The MappingTemplate claims ^.*$ as a valid value pattern. I understand that this is meant to allow arbitrary strings, but actually newline characters are rejected.

This PR removes MappingTemplate-based rules. The rules that are actually removed are:

  • aws_appsync_function_invalid_request_mapping_template
  • aws_appsync_function_invalid_response_mapping_template
  • aws_appsync_resolver_invalid_request_template
  • aws_appsync_resolver_invalid_response_template

@wata727 wata727 merged commit 053a8c4 into master Mar 18, 2023
@wata727 wata727 deleted the remove_invalid_regexp_template_rules branch March 18, 2023 09:00
ewbankkit added a commit to hashicorp/terraform-provider-aws that referenced this pull request Jun 23, 2023
@ewbankkit
Rules removed: terraform-linters/tflint-ruleset-aws#462.
d7e6807
@DanielMSchmidt DanielMSchmidt mentioned this pull request Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_appsync_resolver_invalid_request_template rejects valid template
1 participant
@wata727