Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): group dependency updates #2208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenrui333
Copy link
Contributor

Signed-off-by: Rui Chen <rui@chenrui.dev>
@wata727
Copy link
Member

wata727 commented Jan 15, 2025

Thank you for working on this.

Personally, I think grouping related things together is a good idea, but I'm not a big fan of grouping by package ecosystem. I'm concerned that updating multiple packages with different concerns in a single PR will make it difficult to track changes.

Please let me know if there's any reason why you'd like to move this PR forward.

@bendrucker
Copy link
Member

Yeah to me this feature is built for large packages that are published as smaller units (e.g., AWS SDK) or related packages (e.g., for a linter). In these cases merging many updates one at a time can be at best tedious (SDK) and at worst impossible (in the case of tightly coupled dependencies, e.g., a tool and its plugins). Grouping on ecosystem spoils the signal of a test failure for a given dependency update. A big reason for automated dependency updates is to see exactly where something breaks rather than having to handle big version jumps across many packages.

@chenrui333
Copy link
Contributor Author

yeah, I can see the risk of group updates would incur breaking changes, but in reality, it just never happens.

I also just saw this feature recently (apparently it has been around for quite some time).

I'd like to propose to merge it and see if it indeed cause some issues (I also tried in my other projects too)

let me know what you guys think.

@bendrucker
Copy link
Member

in reality, it just never happens

This is normal though, most dependency updates are noops, but occasionally they matter.

What would be the goal of grouping all dependencies regardless in a single PR? If it's to reduce toil, auto-merging PRs would seem to be a better way to accomplish that without giving up incremental visibility when something does fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants