Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filter to data.aws_eip #3525

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Conversation

richardbowden
Copy link
Contributor

@richardbowden richardbowden commented Feb 25, 2018

fixes issue #3423

this is based of PR "#3522"

Had to fix the failing tests before I could submit this PR.

this addes the ability to search for EIP’s via tags or other attribute that EIP’s can use in a filter.

This did highlight a known issue with regrads to how terraform eval’s data sources before they should if be the resourse is a computed value. This is only an issue if the data block is referencing a resource that is created at the same time. If referencing a pre exiting resource this does not happen.

the test config testAccDataSourceAwsEipFilterConfig makes a interpol ref to force terraform to eval the data block after the resource has either been created or read in values = ["${aws_eip.test.tags.Name}”] see the following links

hashicorp/terraform#10603
hashicorp/terraform#17173

www and others added 3 commits February 25, 2018 16:09
this addes the ability to search for EIP’s via tags or other attribute that EIP’s can use in a filter.

This did highlight a known issue with regrads to how terraform eval’s data sources before they should if be the resourse is a computed value. This is only an issue if the data block is referencing a resource that is created at the same time. If referencing a pre exiting resource this does not happen.

the test config testAccDataSourceAwsEipFilterConfig makes a interpol ref to force terraform to eval the data block after the resource has either been created or read in `values = ["${aws_eip.test.tags.Name}”]` see the following links

hashicorp/terraform#10603
hashicorp/terraform#17173
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 25, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 27, 2018
@richardbowden richardbowden changed the title Adds filter to data.aws_eip fixes #3423 depends on PR3522 Adds filter to data.aws_eip Feb 27, 2018
@crohr
Copy link

crohr commented Jul 5, 2018

Any chance to see this merged? In our case it would be very valuable to be able to setup a fixed pool of EIPs, and assign them to instances via a data source. This makes sure we always keep the same EIPs in case we have to open firewalls etc.

@msays2000
Copy link

curious when will this make it in ?

@bflad bflad added this to the v1.45.0 milestone Nov 7, 2018
@bflad bflad merged commit 10f42ab into hashicorp:master Nov 13, 2018
bflad added a commit that referenced this pull request Nov 13, 2018
```
--- PASS: TestAccDataSourceAwsEip_PublicIP_EC2Classic (8.56s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (11.76s)
--- PASS: TestAccDataSourceAwsEip_Id (11.79s)
--- PASS: TestAccDataSourceAwsEip_Tags (12.45s)
--- PASS: TestAccDataSourceAwsEip_Filter (12.58s)
```
@bflad bflad modified the milestones: v1.45.0, v1.44.0 Nov 13, 2018
bflad added a commit that referenced this pull request Nov 13, 2018
@bflad
Copy link
Contributor

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants