New Resource: aws_s3_account_public_access_block #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
new-resource
ghost
added
size/XXL
2 tasks
This implements Public Access Block configuration within the new S3 Control API, which is separate from the existing S3 API. The S3 Control API features the same eventual consistency complexity as the existing S3 API across all operations. The resource and acceptance testing try handling the eventual consistency as best as possible up to a minute.
The resource is named `aws_s3_account_public_access_block` instead of `aws_s3control_public_access_block` to be more operator friendly with respect to it working at the account level.
Changes:
* provider: Implement S3 Control custom endpoint, session, and connection
* New Resource: aws_s3_account_public_access_block
Output from acceptance testing:
```
--- PASS: TestAccAWSS3Account (169.55s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock (169.55s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/basic (13.01s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/disappears (7.95s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/AccountId (11.47s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/BlockPublicAcls (25.04s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/BlockPublicPolicy (25.33s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/IgnorePublicAcls (25.33s)
--- PASS: TestAccAWSS3Account/PublicAccessBlock/RestrictPublicBuckets (26.40s)
```
bflad
force-pushed
the
f-aws_s3_account_public_block_policy
branch
from
12d1841
to
93c112a
Compare
ghost
added
size/XL
|
This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #6489
This implements Public Access Block configuration within the new S3 Control API, which is separate from the existing S3 API. The S3 Control API features the same eventual consistency complexity as the existing S3 API across all operations. The resource and acceptance testing try handling the eventual consistency as best as possible up to a minute.
The resource is named
aws_s3_account_public_access_blockinstead ofaws_s3control_public_access_blockto be more operator friendly with respect to it working at the account level.Changes:
aws_s3_account_public_access_blockOutput from acceptance testing (explicitly serialized for TeamCity):