Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/servicediscovery: Return operation ErrorCode and ErrorMessage when Status is FAIL #7118

Merged
merged 1 commit into from
Jan 14, 2019
Merged

service/servicediscovery: Return operation ErrorCode and ErrorMessage when Status is FAIL #7118

merged 1 commit into from
Jan 14, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 11, 2019

Fixes #2830
Fixes #5532

Previously, the full error messaging from the API response was not present when an operation failed:

aws_service_discovery_private_dns_namespace.subdomain: unexpected state 'FAIL', wanted target 'SUCCESS'. last error: %!s(<nil>)

This change returns the ErrorCode and ErrorMessage fields from the API response:

aws_service_discovery_private_dns_namespace.subdomain: CANNOT_CREATE_HOSTED_ZONE: The VPC that you chose, vpc-0c04acdb2f40a49d6 in region us-west-2, is already associated with another private hosted zone that has an overlapping name space, wavsx.example.com.. (Service: AmazonRoute53; Status Code: 400; Error Code: ConflictingDomainExists; Request ID: 600b3096-15c4-11e9-97af-ade1478492a8)

Output from acceptance testing:

--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_basic (96.16s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname (105.49s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_basic (105.77s)
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_Description (105.87s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_longname (105.92s)
--- PASS: TestAccAWSServiceDiscoveryService_import (108.32s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic (116.13s)
--- PASS: TestAccAWSServiceDiscoveryService_private (122.87s)
--- PASS: TestAccAWSServiceDiscoveryService_public (133.85s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_error_Overlap (188.37s)

@bflad
service/servicediscovery: Return operation ErrorCode and ErrorMessage…
2a938f0 
… when Status is FAIL

Previously, the full error messaging from the API response was not present when an operation failed:

```
aws_service_discovery_private_dns_namespace.subdomain: unexpected state 'FAIL', wanted target 'SUCCESS'. last error: %!s(<nil>)
```

This change returns the ErrorCode and ErrorMessage fields from the API response:

```
aws_service_discovery_private_dns_namespace.subdomain: CANNOT_CREATE_HOSTED_ZONE: The VPC that you chose, vpc-0c04acdb2f40a49d6 in region us-west-2, is already associated with another private hosted zone that has an overlapping name space, wavsx.example.com.. (Service: AmazonRoute53; Status Code: 400; Error Code: ConflictingDomainExists; Request ID: 600b3096-15c4-11e9-97af-ade1478492a8)
```

Output from acceptance testing:

```
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_basic (96.16s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname (105.49s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_basic (105.77s)
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_Description (105.87s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_longname (105.92s)
--- PASS: TestAccAWSServiceDiscoveryService_import (108.32s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic (116.13s)
--- PASS: TestAccAWSServiceDiscoveryService_private (122.87s)
--- PASS: TestAccAWSServiceDiscoveryService_public (133.85s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_error_Overlap (188.37s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. labels Jan 11, 2019
@bflad bflad requested a review from a team January 11, 2019 17:27
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
mbfrahry
mbfrahry approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.56.0 milestone Jan 14, 2019
@bflad bflad merged commit c5c51b1 into master Jan 14, 2019
@bflad bflad deleted the b-servicediscovery-full-errors branch January 14, 2019 13:22
bflad added a commit that referenced this pull request Jan 14, 2019
@bflad
Update CHANGELOG for #7118
fb53894
@bflad
Copy link
Contributor Author

bflad commented Jan 16, 2019

This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.56.0
2 participants
@bflad @mbfrahry