Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Transit gateway blackhole route #9224

Merged
merged 3 commits into from
Jul 4, 2019
Merged

Add support for Transit gateway blackhole route #9224

merged 3 commits into from
Jul 4, 2019

Conversation

anouvel
Copy link
Contributor

@anouvel anouvel commented Jul 3, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9046

Release note for CHANGELOG:

resource/aws_ec2_transit_gateway_route: Add support for blackhole routes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TransitGatewayRoute_blackhole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEc2TransitGatewayRoute_blackhole -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEc2TransitGatewayRoute_blackhole
=== PAUSE TestAccAWSEc2TransitGatewayRoute_blackhole
=== CONT  TestAccAWSEc2TransitGatewayRoute_blackhole
--- PASS: TestAccAWSEc2TransitGatewayRoute_blackhole (410.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       410.451s

@anouvel anouvel requested a review from a team July 3, 2019 14:29
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 3, 2019
@anouvel anouvel force-pushed the transit_gateway_blackhole_route branch from dc7be4c to 7fa6514 Compare July 3, 2019 14:34
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 4, 2019
bflad
bflad approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks, @anouvel! 🚀

--- PASS: TestAccAWSEc2TransitGatewayRoute_disappears_TransitGatewayAttachment (326.44s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic (326.90s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_blackhole (330.77s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_disappears (391.53s)

@bflad bflad added this to the v2.18.0 milestone Jul 4, 2019
@bflad bflad merged commit 61d69b9 into hashicorp:master Jul 4, 2019
bflad added a commit that referenced this pull request Jul 4, 2019
@bflad
Update CHANGELOG for #9224
cfcacea
@bflad
Copy link
Contributor

bflad commented Jul 5, 2019

This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@jayparekhjp jayparekhjp mentioned this pull request Jul 25, 2019
Closed
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.

Add blackhole Attribute to aws_ec2_transit_gateway_route
2 participants
@anouvel @bflad