Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_apigatewayv2_authorizer #9228

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 3, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_authorizer

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Authorizer_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Authorizer_basic
=== PAUSE TestAccAWSAPIGateway2Authorizer_basic
=== RUN   TestAccAWSAPIGateway2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGateway2Authorizer_Credentials
=== CONT  TestAccAWSAPIGateway2Authorizer_basic
=== CONT  TestAccAWSAPIGateway2Authorizer_Credentials
--- PASS: TestAccAWSAPIGateway2Authorizer_basic (45.99s)
--- PASS: TestAccAWSAPIGateway2Authorizer_Credentials (84.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	84.802s

Currently based on #8842, will need to rebase once that PR is merged.

@ewbankkit ewbankkit requested a review from a team July 3, 2019 17:57
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 3, 2019
@ewbankkit ewbankkit mentioned this pull request Jul 3, 2019
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch from afed9d2 to 8439df3 Compare July 3, 2019 20:10
@ewbankkit ewbankkit changed the title [WIP] New resource: aws_api_gateway_v2_authorizer New resource: aws_api_gateway_v2_authorizer Jul 3, 2019
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch from 8439df3 to 5f5e59c Compare July 3, 2019 20:37
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch from 5f5e59c to 9777911 Compare July 26, 2019 19:42
@ewbankkit
Copy link
Contributor Author

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Authorizer_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Authorizer_basic
=== PAUSE TestAccAWSAPIGateway2Authorizer_basic
=== RUN   TestAccAWSAPIGateway2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGateway2Authorizer_Credentials
=== CONT  TestAccAWSAPIGateway2Authorizer_basic
=== CONT  TestAccAWSAPIGateway2Authorizer_Credentials
--- PASS: TestAccAWSAPIGateway2Authorizer_basic (46.21s)
--- PASS: TestAccAWSAPIGateway2Authorizer_Credentials (76.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.402s

@ewbankkit
Copy link
Contributor Author

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Authorizer_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Authorizer_basic
=== PAUSE TestAccAWSAPIGateway2Authorizer_basic
=== RUN   TestAccAWSAPIGateway2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGateway2Authorizer_Credentials
=== CONT  TestAccAWSAPIGateway2Authorizer_basic
=== CONT  TestAccAWSAPIGateway2Authorizer_Credentials
--- PASS: TestAccAWSAPIGateway2Authorizer_basic (39.61s)
--- PASS: TestAccAWSAPIGateway2Authorizer_Credentials (76.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.577s

@aeschright aeschright added the new-resource Introduces a new resource. label Aug 19, 2019
@ewbankkit ewbankkit changed the title New resource: aws_api_gateway_v2_authorizer New resource: aws_apigatewayv2_authorizer Mar 13, 2020
@ewbankkit
Copy link
Contributor Author

After merge of #8842, incorporate all the feedback:

  • Migrate to Terraform provider SDK
  • Change resource name to aws_apigatewayv2_blah; Rename source files
  • Remove sidebar_current from documentation
  • Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
  • Change function names to ApiGatewayV2
  • Add _disappears acceptance test
  • Use multierror in any test sweeper

@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch from 75b0f33 to c7d98c0 Compare March 13, 2020 16:12
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 13, 2020
@ewbankkit
Copy link
Contributor Author

Renamed resource to aws_apigatewayv2_authorizer.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Authorizer_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Authorizer_basic
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_basic
=== RUN   TestAccAWSAPIGatewayV2Authorizer_disappears
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_disappears
=== RUN   TestAccAWSAPIGatewayV2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_Credentials
=== CONT  TestAccAWSAPIGatewayV2Authorizer_basic
=== CONT  TestAccAWSAPIGatewayV2Authorizer_Credentials
=== CONT  TestAccAWSAPIGatewayV2Authorizer_disappears
--- PASS: TestAccAWSAPIGatewayV2Authorizer_disappears (49.76s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_basic (63.81s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_Credentials (104.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	104.529s

@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch 2 times, most recently from d081af9 to 10d45d7 Compare March 13, 2020 22:29
@ewbankkit
Copy link
Contributor Author

Added support for JWT authorizers for HTTP APIs.
Acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Authorizer_JWT'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Authorizer_JWT -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Authorizer_JWT
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_JWT
=== CONT  TestAccAWSAPIGatewayV2Authorizer_JWT
--- PASS: TestAccAWSAPIGatewayV2Authorizer_JWT (66.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.690s

@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch from f7fe90f to 7178b17 Compare March 15, 2020 22:58
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_authorizer branch from 7178b17 to 4c27f54 Compare March 16, 2020 20:50
@ewbankkit
Copy link
Contributor Author

This is now ready for review.

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Authorizer_JWT (32.45s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_disappears (39.37s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_basic (40.71s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_Credentials (51.02s)

@gdavison gdavison added this to the v2.57.0 milestone Apr 7, 2020
@gdavison gdavison merged commit cd65388 into hashicorp:master Apr 8, 2020
gdavison added a commit that referenced this pull request Apr 8, 2020
@ewbankkit ewbankkit deleted the issue-7004.aws_api_gateway_v2_authorizer branch April 9, 2020 10:03
@ghost
Copy link

ghost commented Apr 10, 2020

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants