New resource: aws_apigatewayv2_route #8881

ewbankkit · 2019-06-05T22:17:19Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_route

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Route_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Route_basic
=== PAUSE TestAccAWSAPIGateway2Route_basic
=== RUN   TestAccAWSAPIGateway2Route_Authorizer
=== PAUSE TestAccAWSAPIGateway2Route_Authorizer
=== RUN   TestAccAWSAPIGateway2Route_Model
=== PAUSE TestAccAWSAPIGateway2Route_Model
=== RUN   TestAccAWSAPIGateway2Route_SimpleAttributes
=== PAUSE TestAccAWSAPIGateway2Route_SimpleAttributes
=== RUN   TestAccAWSAPIGateway2Route_Target
=== PAUSE TestAccAWSAPIGateway2Route_Target
=== CONT  TestAccAWSAPIGateway2Route_basic
=== CONT  TestAccAWSAPIGateway2Route_Target
=== CONT  TestAccAWSAPIGateway2Route_SimpleAttributes
=== CONT  TestAccAWSAPIGateway2Route_Model
=== CONT  TestAccAWSAPIGateway2Route_Authorizer
--- PASS: TestAccAWSAPIGateway2Route_basic (21.57s)
--- PASS: TestAccAWSAPIGateway2Route_Model (23.63s)
--- PASS: TestAccAWSAPIGateway2Route_Target (33.68s)
--- PASS: TestAccAWSAPIGateway2Route_SimpleAttributes (46.55s)
--- PASS: TestAccAWSAPIGateway2Route_Authorizer (59.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.142s

Currently based on #8842, will need to rebase once that PR is merged.

ewbankkit · 2019-06-07T16:20:26Z

Acceptance tests so far:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Route_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Route_basic
=== PAUSE TestAccAWSAPIGateway2Route_basic
=== RUN   TestAccAWSAPIGateway2Route_update
=== PAUSE TestAccAWSAPIGateway2Route_update
=== CONT  TestAccAWSAPIGateway2Route_basic
=== CONT  TestAccAWSAPIGateway2Route_update
--- PASS: TestAccAWSAPIGateway2Route_basic (25.74s)
--- PASS: TestAccAWSAPIGateway2Route_update (65.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	65.224s

Testing additional attributes requires additional resources for authorizers, models and integrations.

ewbankkit · 2019-07-01T16:57:49Z

Rebased to track #8842 (comment).

ewbankkit · 2019-07-13T21:47:21Z

Includes

New resource: aws_apigatewayv2_authorizer #9228 for aws_api_gateway_v2_authorizer tests
New resource: aws_apigatewayv2_model #8912 for aws_api_gateway_v2_model tests
New resource: aws_apigatewayv2_integration #8949 for aws_api_gateway_v2_integration tests

Will need to rebase as these are merged.

ewbankkit · 2019-07-26T20:41:58Z

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Route_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Route_basic
=== PAUSE TestAccAWSAPIGateway2Route_basic
=== RUN   TestAccAWSAPIGateway2Route_Authorizer
=== PAUSE TestAccAWSAPIGateway2Route_Authorizer
=== RUN   TestAccAWSAPIGateway2Route_Model
=== PAUSE TestAccAWSAPIGateway2Route_Model
=== RUN   TestAccAWSAPIGateway2Route_SimpleAttributes
=== PAUSE TestAccAWSAPIGateway2Route_SimpleAttributes
=== RUN   TestAccAWSAPIGateway2Route_Target
=== PAUSE TestAccAWSAPIGateway2Route_Target
=== CONT  TestAccAWSAPIGateway2Route_basic
=== CONT  TestAccAWSAPIGateway2Route_Target
=== CONT  TestAccAWSAPIGateway2Route_SimpleAttributes
=== CONT  TestAccAWSAPIGateway2Route_Model
=== CONT  TestAccAWSAPIGateway2Route_Authorizer
--- PASS: TestAccAWSAPIGateway2Route_Target (23.34s)
--- PASS: TestAccAWSAPIGateway2Route_basic (23.52s)
--- PASS: TestAccAWSAPIGateway2Route_Model (39.58s)
--- PASS: TestAccAWSAPIGateway2Route_SimpleAttributes (48.75s)
--- PASS: TestAccAWSAPIGateway2Route_Authorizer (58.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	58.882s

ewbankkit · 2019-08-16T18:01:29Z

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Route_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Route_basic
=== PAUSE TestAccAWSAPIGateway2Route_basic
=== RUN   TestAccAWSAPIGateway2Route_Authorizer
=== PAUSE TestAccAWSAPIGateway2Route_Authorizer
=== RUN   TestAccAWSAPIGateway2Route_Model
=== PAUSE TestAccAWSAPIGateway2Route_Model
=== RUN   TestAccAWSAPIGateway2Route_SimpleAttributes
=== PAUSE TestAccAWSAPIGateway2Route_SimpleAttributes
=== RUN   TestAccAWSAPIGateway2Route_Target
=== PAUSE TestAccAWSAPIGateway2Route_Target
=== CONT  TestAccAWSAPIGateway2Route_basic
=== CONT  TestAccAWSAPIGateway2Route_Target
=== CONT  TestAccAWSAPIGateway2Route_SimpleAttributes
=== CONT  TestAccAWSAPIGateway2Route_Model
=== CONT  TestAccAWSAPIGateway2Route_Authorizer
--- PASS: TestAccAWSAPIGateway2Route_Target (23.40s)
--- PASS: TestAccAWSAPIGateway2Route_Model (29.59s)
--- PASS: TestAccAWSAPIGateway2Route_basic (31.16s)
--- PASS: TestAccAWSAPIGateway2Route_SimpleAttributes (57.02s)
--- PASS: TestAccAWSAPIGateway2Route_Authorizer (57.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.949s

ewbankkit · 2020-04-09T12:16:08Z

After merge of #8949, #8912 and #9228, incorporate all the feedback:

Migrate to Terraform provider SDK
Change resource name to aws_apigatewayv2_blah; Rename source files
Remove sidebar_current from documentation
Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
Change function names to ApiGatewayV2
Add _disappears acceptance test
Use multierror in any test sweeper

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Route_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Route_ -timeout 120m === RUN TestAccAWSAPIGatewayV2Route_basic === PAUSE TestAccAWSAPIGatewayV2Route_basic === RUN TestAccAWSAPIGatewayV2Route_disappears === PAUSE TestAccAWSAPIGatewayV2Route_disappears === RUN TestAccAWSAPIGatewayV2Route_Model === PAUSE TestAccAWSAPIGatewayV2Route_Model === RUN TestAccAWSAPIGatewayV2Route_SimpleAttributes === PAUSE TestAccAWSAPIGatewayV2Route_SimpleAttributes === RUN TestAccAWSAPIGatewayV2Route_Target === PAUSE TestAccAWSAPIGatewayV2Route_Target === CONT TestAccAWSAPIGatewayV2Route_basic === CONT TestAccAWSAPIGatewayV2Route_SimpleAttributes === CONT TestAccAWSAPIGatewayV2Route_Model === CONT TestAccAWSAPIGatewayV2Route_Target === CONT TestAccAWSAPIGatewayV2Route_disappears --- PASS: TestAccAWSAPIGatewayV2Route_disappears (23.60s) --- PASS: TestAccAWSAPIGatewayV2Route_basic (26.45s) --- PASS: TestAccAWSAPIGatewayV2Route_Target (28.53s) --- PASS: TestAccAWSAPIGatewayV2Route_Model (29.18s) --- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (58.48s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 58.539s

ewbankkit · 2020-04-09T21:27:45Z

Renamed resource to aws_apigatewayv2_route.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Route_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Route_basic
=== PAUSE TestAccAWSAPIGatewayV2Route_basic
=== RUN   TestAccAWSAPIGatewayV2Route_disappears
=== PAUSE TestAccAWSAPIGatewayV2Route_disappears
=== RUN   TestAccAWSAPIGatewayV2Route_Authorizer
=== PAUSE TestAccAWSAPIGatewayV2Route_Authorizer
=== RUN   TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== PAUSE TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== RUN   TestAccAWSAPIGatewayV2Route_Model
=== PAUSE TestAccAWSAPIGatewayV2Route_Model
=== RUN   TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== PAUSE TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== RUN   TestAccAWSAPIGatewayV2Route_Target
=== PAUSE TestAccAWSAPIGatewayV2Route_Target
=== CONT  TestAccAWSAPIGatewayV2Route_basic
=== CONT  TestAccAWSAPIGatewayV2Route_Model
=== CONT  TestAccAWSAPIGatewayV2Route_Target
=== CONT  TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== CONT  TestAccAWSAPIGatewayV2Route_Authorizer
=== CONT  TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== CONT  TestAccAWSAPIGatewayV2Route_disappears
--- PASS: TestAccAWSAPIGatewayV2Route_disappears (23.66s)
--- PASS: TestAccAWSAPIGatewayV2Route_basic (27.63s)
--- PASS: TestAccAWSAPIGatewayV2Route_Model (29.72s)
--- PASS: TestAccAWSAPIGatewayV2Route_Target (29.80s)
--- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (59.29s)
--- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (67.32s)
--- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (76.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.442s

ewbankkit · 2020-04-09T21:32:30Z

This is now ready for review.

gdavison

One comment on the documentation, but otherwise, LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Route_disappears (9.94s)
--- PASS: TestAccAWSAPIGatewayV2Route_basic (10.62s)
--- PASS: TestAccAWSAPIGatewayV2Route_Target (11.13s)
--- PASS: TestAccAWSAPIGatewayV2Route_Model (18.21s)
--- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (20.87s)
--- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (22.82s)
--- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (42.87s)

gdavison · 2020-04-14T22:40:38Z

aws/resource_aws_apigatewayv2_route_test.go

+			return fmt.Errorf("Not Found: %s", integrationResourceName)
+		}
+
+		return resource.TestCheckResourceAttr(resourceName, "target", fmt.Sprintf("integrations/%s", rs.Primary.ID))(s)


I like how you implemented this to get the specific value

gdavison · 2020-04-14T22:51:24Z

website/docs/r/apigatewayv2_route.html.markdown

+
+## Import
+
+`aws_apigatewayv2_route` can be imported by using the API identifier and route identifier, e.g.


Since routes managed by API Gateway cannot be imported, please add a note in this section indicating that.

Done. Added the same for the aws_apigatewayv2_integration resource.

…resources created as part of API quick create.

ghost · 2020-04-17T00:45:05Z

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-05-16T17:10:19Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit mentioned this pull request Jun 5, 2019

API Gateway- Websocket #7004

Closed

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route branch 2 times, most recently from f5f1093 to 7b58039 Compare June 7, 2019 16:18

kapilt mentioned this pull request Jun 10, 2019

terraform support aws/chalice#1129

Merged

aeschright requested a review from a team June 28, 2019 18:14

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route branch from 836235b to 6832550 Compare July 1, 2019 16:57

ghost added size/XXL Managed by automation to categorize the size of a PR. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 1, 2019

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route branch from 6832550 to a228787 Compare July 2, 2019 18:08

ewbankkit mentioned this pull request Jul 5, 2019

New resource: aws_apigatewayv2_deployment #9245

Merged

ewbankkit changed the title ~~[WIP] New resource: aws_api_gateway_v2_route~~ New resource: aws_api_gateway_v2_route Jul 13, 2019

ewbankkit mentioned this pull request Jul 16, 2019

New resource: aws_apigatewayv2_route_response #9373

Merged

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route branch from ac0ec49 to 1468489 Compare July 26, 2019 20:41

aeschright added the new-resource Introduces a new resource. label Aug 19, 2019

ewbankkit mentioned this pull request Mar 14, 2020

Amazon API Gateway HTTP APIs #11148

Closed

Add 'aws_api_gateway_v2_route' resource.

e6e5b77

ewbankkit changed the title ~~New resource: aws_api_gateway_v2_route~~ New resource: aws_apigatewayv2_route Apr 9, 2020

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route branch from 6a80c6c to 8aa0e7c Compare April 9, 2020 21:26

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Apr 9, 2020

r/aws_apigatewayv2_route: Add support for JWT authorizers.

4ba6eba

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route branch from 8aa0e7c to 4ba6eba Compare April 9, 2020 21:32

gdavison approved these changes Apr 14, 2020

View reviewed changes

bflad removed the service/apigateway Issues and PRs that pertain to the apigateway service. label Apr 15, 2020

Add note to documentation on inability to import API Gateway managed …

bd4c798

…resources created as part of API quick create.

gdavison merged commit e899956 into hashicorp:master Apr 15, 2020

gdavison added a commit that referenced this pull request Apr 15, 2020

Update CHANGELOG for #8881

e307efc

gdavison added this to the v2.58.0 milestone Apr 15, 2020

ewbankkit deleted the issue-7004.aws_api_gateway_v2_route branch April 15, 2020 17:39

ewbankkit mentioned this pull request Apr 22, 2020

New data source: aws_apigatewayv2_route #12955

Open

ghost locked and limited conversation to collaborators May 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_apigatewayv2_route #8881

New resource: aws_apigatewayv2_route #8881

ewbankkit commented Jun 5, 2019 •

edited

Loading

ewbankkit commented Jun 7, 2019 •

edited

Loading

ewbankkit commented Jul 1, 2019

ewbankkit commented Jul 13, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Aug 16, 2019

ewbankkit commented Apr 9, 2020

ewbankkit commented Apr 9, 2020

ewbankkit commented Apr 9, 2020

gdavison left a comment

gdavison Apr 14, 2020

gdavison Apr 14, 2020

ewbankkit Apr 15, 2020

ghost commented Apr 17, 2020

ghost commented May 16, 2020


		## Import

		`aws_apigatewayv2_route` can be imported by using the API identifier and route identifier, e.g.

New resource: aws_apigatewayv2_route #8881

New resource: aws_apigatewayv2_route #8881

Conversation

ewbankkit commented Jun 5, 2019 • edited Loading

Community Note

ewbankkit commented Jun 7, 2019 • edited Loading

ewbankkit commented Jul 1, 2019

ewbankkit commented Jul 13, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Aug 16, 2019

ewbankkit commented Apr 9, 2020

ewbankkit commented Apr 9, 2020

ewbankkit commented Apr 9, 2020

gdavison left a comment

Choose a reason for hiding this comment

gdavison Apr 14, 2020

Choose a reason for hiding this comment

gdavison Apr 14, 2020

Choose a reason for hiding this comment

ewbankkit Apr 15, 2020

Choose a reason for hiding this comment

ghost commented Apr 17, 2020

ghost commented May 16, 2020

ewbankkit commented Jun 5, 2019 •

edited

Loading

ewbankkit commented Jun 7, 2019 •

edited

Loading