-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: aws_apigatewayv2_model #8912
New resource: aws_apigatewayv2_model #8912
Conversation
51f0ed3
to
9d494ab
Compare
1a31e17
to
b422661
Compare
Rebased to track #8842 (comment). |
b422661
to
ba8fb18
Compare
Rebased to fix merge conflict. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Model_ -timeout 120m
=== RUN TestAccAWSAPIGateway2Model_basic
=== PAUSE TestAccAWSAPIGateway2Model_basic
=== RUN TestAccAWSAPIGateway2Model_AllAttributes
=== PAUSE TestAccAWSAPIGateway2Model_AllAttributes
=== CONT TestAccAWSAPIGateway2Model_basic
=== CONT TestAccAWSAPIGateway2Model_AllAttributes
--- PASS: TestAccAWSAPIGateway2Model_basic (21.47s)
--- PASS: TestAccAWSAPIGateway2Model_AllAttributes (48.11s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 48.137s |
ba8fb18
to
6a21dc2
Compare
a8172b8
to
4c80818
Compare
Rebased to remove merge conflicts. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Model_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2Model_basic
=== PAUSE TestAccAWSAPIGatewayV2Model_basic
=== RUN TestAccAWSAPIGatewayV2Model_disappears
=== PAUSE TestAccAWSAPIGatewayV2Model_disappears
=== RUN TestAccAWSAPIGatewayV2Model_AllAttributes
=== PAUSE TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT TestAccAWSAPIGatewayV2Model_basic
=== CONT TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT TestAccAWSAPIGatewayV2Model_disappears
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (23.42s)
--- PASS: TestAccAWSAPIGatewayV2Model_basic (27.38s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (59.17s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 59.213s |
After merge of #8842, incorporate all the feedback:
|
4c80818
to
3a96ff7
Compare
3a96ff7
to
78f1007
Compare
Renamed resource to $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Model_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2Model_basic
=== PAUSE TestAccAWSAPIGatewayV2Model_basic
=== RUN TestAccAWSAPIGatewayV2Model_disappears
=== PAUSE TestAccAWSAPIGatewayV2Model_disappears
=== RUN TestAccAWSAPIGatewayV2Model_AllAttributes
=== PAUSE TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT TestAccAWSAPIGatewayV2Model_basic
=== CONT TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT TestAccAWSAPIGatewayV2Model_disappears
--- PASS: TestAccAWSAPIGatewayV2Model_basic (27.39s)
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (27.85s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (61.90s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 61.953s |
8e64894
to
1148afd
Compare
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (9.08s)
--- PASS: TestAccAWSAPIGatewayV2Model_basic (16.30s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (27.84s)
resource.TestCheckResourceAttr(resourceName, "content_type", "application/json"), | ||
resource.TestCheckResourceAttr(resourceName, "description", ""), | ||
resource.TestCheckResourceAttr(resourceName, "name", rName), | ||
resource.TestCheckResourceAttr(resourceName, "schema", schema), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function testAccCheckResourceAttrEquivalentJSON
can be used so that both JSON objects can be normalized
} | ||
} | ||
` | ||
schema2 := ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For readability, please update the formatting on schema2
to match other JSON strings
1148afd
to
d1f1d14
Compare
Rebased to pick up |
This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Another resource for #7004.
Release note for CHANGELOG:
Output from acceptance testing:
Currently based on #8842, will need to rebase once that PR is merged.