New Resource: Add DDos Protection Plan for Virtual Network.

[metacpp]

This PR introduces:

1. New resource (requested in [Feature Request]DDOS Protection Plan #2584, azurerm_ddos_protection_plan, which is only allowed per region.
2. New field, ddos_protection_plan, in azurerm_virtual_network.

[katbyte]

@metacpp,

Does you description indicate there can be only one? if that is the case your tests will need to be refactored into a single test case, and a note on the docs might be helpful as well.

[metacpp]

Does you description indicate there can be only one?
@katbyte Yes, and I grouped all the tests into group test.

[katbyte]

Hi @metacpp, thanks for the udpates,

I've left a few comments inline.

[katbyte]

Thanks @metacpp, LGTM now 🚀

[hbuckle]

@katbyte, @metacpp I was developing something else against a build of master and I think I found a small bug in this - Azure seems to default ddos protection to false even when not specified, so you always get a diff

resource "azurerm_resource_group" "resource_group" {
  name     = "hbtest_vnet"
  location = "uksouth"
}

resource "azurerm_virtual_network" "virtual_network" {
  name                = "hbtest_vnet"
  address_space       = ["10.0.0.0/16"]
  location            = "${azurerm_resource_group.resource_group.location}"
  resource_group_name = "${azurerm_resource_group.resource_group.name}"
}

terraform apply -auto-approve

azurerm_resource_group.resource_group: Creating...
  location: "" => "uksouth"
  name:     "" => "hbtest_vnet"
  tags.%:   "" => "<computed>"
azurerm_resource_group.resource_group: Creation complete after 1s (ID: /subscriptions/020ef497-e33d-4705-859b-08663256a4bc/resourceGroups/hbtest_vnet)
azurerm_virtual_network.virtual_network: Creating...
  address_space.#:     "" => "1"
  address_space.0:     "" => "10.0.0.0/16"
  location:            "" => "uksouth"
  name:                "" => "hbtest_vnet"
  resource_group_name: "" => "hbtest_vnet"
  subnet.#:            "" => "<computed>"
  tags.%:              "" => "<computed>"
azurerm_virtual_network.virtual_network: Still creating... (10s elapsed)
azurerm_virtual_network.virtual_network: Creation complete after 11s (ID: /subscriptions/020ef497-e33d-4705-859b-...ft.Network/virtualNetworks/hbtest_vnet)

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

terraform plan

Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

azurerm_resource_group.resource_group: Refreshing state... (ID: /subscriptions/020ef497-e33d-4705-859b-08663256a4bc/resourceGroups/hbtest_vnet)
azurerm_virtual_network.virtual_network: Refreshing state... (ID: /subscriptions/020ef497-e33d-4705-859b-...ft.Network/virtualNetworks/hbtest_vnet)

------------------------------------------------------------------------

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ azurerm_virtual_network.virtual_network
      ddos_protection_plan.#: "1" => "0"


Plan: 0 to add, 1 to change, 0 to destroy.

Json returned from the API

{
  "name": "hbtest_vnet",
  "id": "/subscriptions/xxx/resourceGroups/hbtest_vnet/providers/Microsoft.Network/virtualNetworks/hbtest_vnet",
  "etag": "W/\"0611dcfd-bfc6-43cd-a2af-434ab17f827e\"",
  "type": "Microsoft.Network/virtualNetworks",
  "location": "uksouth",
  "tags": {},
  "properties": {
    "provisioningState": "Succeeded",
    "resourceGuid": "98c5a26b-ab3d-49f9-8564-e15b424f3d37",
    "addressSpace": {
      "addressPrefixes": [
        "10.0.0.0/16"
      ]
    },
    "dhcpOptions": {
      "dnsServers": []
    },
    "virtualNetworkPeerings": [],
    "enableDdosProtection": false,
    "enableVmProtection": false
  }
}

[metacpp]

@hbuckle thanks for reporting this issue, I can reproduce it and I've prepared a quick fix for it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!