Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_account: ignore 500 responses from CheckNameExists() call #3747

Merged
merged 5 commits into from
Jun 28, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jun 28, 2019

The API is suddenly failing with 500s when we check the DB name, so lets ignore it for now.

SDK issue: Azure/azure-sdk-for-go#5157

fixes #3739

@katbyte katbyte added bug service/cosmosdb upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Jun 28, 2019
@katbyte katbyte added this to the v1.31.0 milestone Jun 28, 2019
@katbyte katbyte requested a review from tombuildsstuff June 28, 2019 06:47
@ghost ghost added the size/XS label Jun 28, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

azurerm/resource_arm_cosmosdb_account.go Outdated Show resolved Hide resolved
katbyte and others added 3 commits June 28, 2019 09:44
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@katbyte katbyte merged commit 0a84bf5 into master Jun 28, 2019
@katbyte katbyte deleted the cosmos/ignore_check_500 branch June 28, 2019 18:20
katbyte added a commit that referenced this pull request Jun 28, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 29, 2019
katbyte pushed a commit that referenced this pull request Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/cosmosdb size/XS upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error checking if CosmosDB Account 'XX' already exists
2 participants