Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ipv4_enabled default to true #1926

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#6012.

Adding a default value will only affect people who had already provisioned instances that did not set a value for that field. If they're a second gen user, the server-side default is true, so their state would already have this value set as true. First gen instances have been decommissioned, so there should be ~0 terraform users using them.

Release Note Template for Downstream PRs (will be copied)

* sql: fixed error that occurred on `google_sql_database_instance` when `settings.ip_configuration` was set but `ipv4_enabled` was not set to true and `private_network` was not configured, by defaulting `ipv4_enabled` to true.

Derived from GoogleCloudPlatform/magic-modules#3330

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Apr 3, 2020
@modular-magician modular-magician merged commit e92508e into hashicorp:master Apr 3, 2020
@modular-magician modular-magician deleted the downstream-pr-aecf1bc479c70a47e4279e82f3939e39c297e10a branch November 16, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_sql_database_instance inconsistent defaulting for ipv4_enabled
1 participant