Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful mig instance #2029

Conversation

modular-magician
Copy link
Collaborator

Support for per-instance configs for stateful managed instance groups.

Fine-grained resource attached to instance group manager. Similar resource for regional instance group manager coming soon

This PR modifies VirtualFields in MM to support types other than booleans. This allows for enums to be set on per-instance configs that control the update strategy for the stateful instances.

Release Note Template for Downstream PRs (will be copied)

`google_compute_per_instance_config` (Beta)

Derived from GoogleCloudPlatform/magic-modules#3440

* Add support for stateful disk in mig/regional mig

* Adding types to virtual fields

* Tests to erbs, docs notes, vcr style

* Update timeout custom code

* Make disks an object

* Adding custom expand and flattener to per-instance disk

* Fix per instance config, it has mode and source fields as well

* Require source

* Cleanup

* Update example

* Only generate per instance config test in beta

* Add test with multiple disks on a stateful instance, PR feedback

* PR feedback, ignore virtual fields on import

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 704664a into hashicorp:master May 4, 2020
@modular-magician modular-magician deleted the downstream-pr-be7c5baf8ab0837e104760963f3dac3f42a908f5 branch November 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant