Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing environment variable with secrets in google_cloud_run_service documentation. #3440

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Confusing environment variable with secrets in google_cloud_run_service documentation. #3440

merged 1 commit into from
Jul 22, 2021

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#9575

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#4987

@modular-magician @c2thorn
Confusing environment variable with secrets in `google_cloud_run_serv…
39f9148 
…ice` documentation. (hashicorp#4987)

* clarify cloudrun secret

Co-authored-by: upodroid <cy@borg.dev>

* Bit of formatting

Co-authored-by: Cameron Thornton <camthornton@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0c9e376 into hashicorp:master Jul 22, 2021
@modular-magician modular-magician deleted the downstream-pr-6aa35ff9adec2bedb5d447d3706a4f5b224b6a5f branch November 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing environment variable with secrets in google_cloud_run_service documentation.
1 participant
@modular-magician