Skip to content

Commit

Permalink
Confusing environment variable with secrets in `google_cloud_run_serv…
Browse files Browse the repository at this point in the history
…ice` documentation. (#4987) (#3440)

* clarify cloudrun secret

Co-authored-by: upodroid <cy@borg.dev>

* Bit of formatting

Co-authored-by: Cameron Thornton <camthornton@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Cameron Thornton <camthornton@google.com>
  • Loading branch information
modular-magician and c2thorn authored Jul 22, 2021
1 parent ee2ff83 commit 0c9e376
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
3 changes: 3 additions & 0 deletions .changelog/4987.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
11 changes: 5 additions & 6 deletions google-beta/resource_cloud_run_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -807,12 +807,11 @@ version or an integer for a specific version.`,
Description: `The name of the secret in Cloud Secret Manager. By default, the secret
is assumed to be in the same project.
If the secret is in another project, you must define an alias.
An alias definition has the form:
<alias>:projects/<project-id|project-number>/secrets/<secret-name>.
If multiple alias definitions are needed, they must be separated by
commas.
The alias definitions must be set on the run.googleapis.com/secrets
annotation.`,
You set the <alias> in this field, and create an annotation with the
following structure
"run.googleapis.com/secrets" = "<alias>:projects/<project-id|project-number>/secrets/<secret-name>".
If multiple alias definitions are needed, they must be separated by
commas in the annotation field.`,
},
},
},
Expand Down
11 changes: 5 additions & 6 deletions website/docs/r/cloud_run_service.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -769,12 +769,11 @@ The `secret_key_ref` block supports:
The name of the secret in Cloud Secret Manager. By default, the secret
is assumed to be in the same project.
If the secret is in another project, you must define an alias.
An alias definition has the form:
<alias>:projects/<project-id|project-number>/secrets/<secret-name>.
If multiple alias definitions are needed, they must be separated by
commas.
The alias definitions must be set on the run.googleapis.com/secrets
annotation.
You set the <alias> in this field, and create an annotation with the
following structure
"run.googleapis.com/secrets" = "<alias>:projects/<project-id|project-number>/secrets/<secret-name>".
If multiple alias definitions are needed, they must be separated by
commas in the annotation field.

The `ports` block supports:

Expand Down

0 comments on commit 0c9e376

Please sign in to comment.