Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deletion_protection field for bigtable instance #2061

Conversation

modular-magician
Copy link
Collaborator

I called it allow_destroy to align with prevent_destroy and terraform destroy, but feel free to suggest a different name if you'd like.

I'm not considering this a breaking change because it doesn't affect users until they want to make a change, but let me know if you disagree.

Once this is merged, I'll follow up with the other bigtable resources.

EDIT: it's called deletion_protection now to align with the field in compute instance.

Release Note Template for Downstream PRs (will be copied)

* bigtable: added `deletion_protection` field to `google_bigtable_instance` to make deleting them require an explicit intent.
* `google_bigtable_instance` resources now cannot be destroyed unless `deletion_protection = false` is set in state for the resource.

Derived from GoogleCloudPlatform/magic-modules#3450

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0334d71 into hashicorp:master May 12, 2020
@modular-magician modular-magician deleted the downstream-pr-dd24d60acc6fb2488c51f84f676f56d40cb6c18a branch November 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant