d2-vscode-extension #11

BarryNolte · 2022-12-04T04:51:12Z

First PR creating the viewer for d2 files in VsCode.

#4 - For Reference

Fixes:
#9 and #13

First PR creating the viewer for d2 files in VsCode.

Added wrapper around displayed SVG tag to allow for zooming and fitting to screen.

This reverts commit 55049ca.

This reverts commit d189451.

alixander · 2022-12-05T03:13:32Z

exciting, looking forward to test driving it! (feel free to add me to reviewer when it's rdy)

BarryNolte · 2022-12-05T03:43:13Z

@alixander It’s as ready as it’ll ever be. Only prerequisite needed is to have d2 on your path.

Added context menus everywhere it made sense and changed temp file deletion to be more deterministic.

BarryNolte · 2022-12-06T02:09:19Z

If I can make a change to the d2 executable to not launch the browser when in watch mode (e.g. --nobrowser switch), I can change the extension to connect to the localhost and display the result. Although that might be a cleaner solution, it doesn't allow for multiple input files without additional work (my kludge/solution does allow for this).

alixander · 2022-12-06T02:28:24Z

@BarryNolte BROWSER=0 will be in the next release (https://github.com/terrastruct/d2/blob/master/ci/release/changelogs/next.md). We'll cut it tonight. You can test it now by building from source

gavin-ts

Thanks for setting this up! I added a bunch of notes, but some of these are larger issues to tackle so I was thinking we could merge this into the dev branch after some of the smaller changes and handle the rest in their own PRs?

Looks good with the fit to screen option:

tsconfig.json

src/refreshTimer.ts

src/browserWindow.ts

src/docToPreviewGenerator.ts

src/browserWindow.ts

src/extension.ts

Auto generated spew, no use for it once the project is setup and working. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

This is why I bought one of the first commercially available spell checkers, so I could graduate college. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Setup eslint and fixed errors and warnings. Made "fit" as the default on load Changed update timer code to be simpler Changed preview HTML to load from disk

BarryNolte · 2022-12-23T02:56:43Z

@gavin-ts All requested changes made in commit: 9650284

package.json

gavin-ts

nice we will want to add a note to the PR body that this fixes #9 and #13

.vscode/launch.json

package.json

pages/previewPage.html

src/extension.ts

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

gavin-ts

I think it should be good to merge with these changes

Also noting for a follow up, I think we will want to change the d2 call to be async since it can cause typing in the .d2 file to lag on larger layouts

src/extension.ts

package.json

gavin-ts

nice! it is very nice to have the preview window with render right there while editing .d2 files 🚀

src/extension.ts

.vscode/tasks.json

alixander · 2023-01-11T19:50:34Z

@BarryNolte this looks great, i think this is ready to merge, just wanted to double check with you it's set?

BarryNolte · 2023-01-11T21:26:03Z

@BarryNolte this looks great, i think this is ready to merge, just wanted to double check with you it's set?

Yes, please.

PR #16 has more features, some bug fixes and few better ways of doing things as I figured them out. After that PR is merged, then we can drill down on bugs/features/enhancements with more targeted and smaller PR's.

alixander · 2023-01-11T21:59:37Z

@BarryNolte could you sign the commits please? I have it turned on as a branch protection org-wide. terrastruct/d2#557 (comment)

First PR creating the viewer for d2 files in VsCode. d2-vscode-extension Added wrapper around displayed SVG tag to allow for zooming and fitting to screen. Revert "d2-vscode-extension" This reverts commit 55049ca. Revert "Revert "d2-vscode-extension"" This reverts commit d189451. Added context menus and code cleanup Added context menus everywhere it made sense and changed temp file deletion to be more deterministic. Update tsconfig.json Auto generated spew, no use for it once the project is setup and working. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/refreshTimer.ts This is why I bought one of the first commercially available spell checkers, so I could graduate college. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/docToPreviewGenerator.ts Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/browserWindow.ts Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/browserWindow.ts Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Changes from Review Setup eslint and fixed errors and warnings. Made "fit" as the default on load Changed update timer code to be simpler Changed preview HTML to load from disk Updated branding Update package.json Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update package.json Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

…ode-extension

BarryNolte · 2023-01-12T02:13:19Z

@BarryNolte could you sign the commits please? I have it turned on as a branch protection org-wide. terrastruct/d2#557 (comment)

I tried, but failed to get all commits signed. Couldn't get beyond the latest commit being signed.

alixander · 2023-01-12T03:04:51Z

@BarryNolte looks like it's been set up then, can you rewrite the commits? https://superuser.com/a/1123928 (except replace development)

First PR creating the viewer for d2 files in VsCode. d2-vscode-extension Added wrapper around displayed SVG tag to allow for zooming and fitting to screen. Revert "d2-vscode-extension" This reverts commit 55049ca. Revert "Revert "d2-vscode-extension"" This reverts commit d189451. Added context menus and code cleanup Added context menus everywhere it made sense and changed temp file deletion to be more deterministic. Update tsconfig.json Auto generated spew, no use for it once the project is setup and working. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/refreshTimer.ts This is why I bought one of the first commercially available spell checkers, so I could graduate college. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/docToPreviewGenerator.ts Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/browserWindow.ts Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update src/browserWindow.ts Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Changes from Review Setup eslint and fixed errors and warnings. Made "fit" as the default on load Changed update timer code to be simpler Changed preview HTML to load from disk Updated branding Update package.json Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com> Update package.json Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Added wrapper around displayed SVG tag to allow for zooming and fitting to screen.

This reverts commit 55049ca.

This reverts commit d189451.

Added context menus everywhere it made sense and changed temp file deletion to be more deterministic.

Setup eslint and fixed errors and warnings. Made "fit" as the default on load Changed update timer code to be simpler Changed preview HTML to load from disk

BarryNolte · 2023-01-12T15:57:51Z

@alixander - I was able to partially get commits verified, but not all of them. I had found that article you suggested and thought it would be unpleasant to use that technique, and it was.

Suggestion: Create another PR with one signed commit that's the same as the last commit on this PR. Merge it, and abandon this one. I'll do the same for my other PR and then continue to sign each commit to avoid this in the future.

alixander · 2023-01-12T16:43:19Z

yeah that'd work! @BarryNolte

BarryNolte · 2023-01-12T22:05:36Z

Wow, that should have been easier... See PR #19

After that's merged, we can pull the plug on this PR.

alixander · 2023-01-12T22:15:26Z

sorry about the hoops @BarryNolte , ty for bearing with that, really excited to be merging all this for users (looks like the extension has been downloaded over 3k times now)

BarryNolte · 2023-01-12T22:21:38Z

I've had worse hoops 😄 I probably should have been signing my commits years ago. Lesson learned and my love/hate relationship with git continues. On to the next PR...

BarryNolte added 4 commits December 3, 2022 20:46

d2-vscode-extension

13f3092

First PR creating the viewer for d2 files in VsCode.

d2-vscode-extension

55049ca

Added wrapper around displayed SVG tag to allow for zooming and fitting to screen.

Revert "d2-vscode-extension"

d189451

This reverts commit 55049ca.

Revert "Revert "d2-vscode-extension""

9aaa385

This reverts commit d189451.

alixander self-requested a review December 5, 2022 03:55

Added context menus and code cleanup

20b01ff

Added context menus everywhere it made sense and changed temp file deletion to be more deterministic.

gavin-ts suggested changes Dec 22, 2022

View reviewed changes

kdheepak mentioned this pull request Dec 22, 2022

Render markdown preview with d2 diagrams in code blocks with language d2 #14

Closed

BarryNolte and others added 6 commits December 21, 2022 19:14

Update tsconfig.json

ed90ca2

Auto generated spew, no use for it once the project is setup and working. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Update src/refreshTimer.ts

4051681

This is why I bought one of the first commercially available spell checkers, so I could graduate college. Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Update src/docToPreviewGenerator.ts

ec03fc5

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Update src/browserWindow.ts

7bd47b7

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Update src/browserWindow.ts

f934f9b

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Changes from Review

9650284

Setup eslint and fixed errors and warnings. Made "fit" as the default on load Changed update timer code to be simpler Changed preview HTML to load from disk

BarryNolte mentioned this pull request Dec 24, 2022

D2 vscode format code #15

Closed

aaronjheng reviewed Dec 28, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

Updated branding

3d7a028

BarryNolte requested review from gavin-ts and aaronjheng and removed request for alixander, gavin-ts and aaronjheng December 28, 2022 20:40

gavin-ts suggested changes Dec 28, 2022

View reviewed changes

gavin-ts reviewed Dec 28, 2022

View reviewed changes

src/extension.ts Show resolved Hide resolved

BarryNolte and others added 3 commits December 28, 2022 16:57

Update package.json

0582752

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Update package.json

690c953

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Update pages/previewPage.html

855d816

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

BarryNolte mentioned this pull request Dec 30, 2022

D2 vscode markdown plugin #16

Closed

gavin-ts suggested changes Jan 9, 2023

View reviewed changes

Code review fixes

4e02fc1

gavin-ts approved these changes Jan 10, 2023

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

.vscode/tasks.json Show resolved Hide resolved

BarryNolte and others added 4 commits January 11, 2023 17:55

Update pages/previewPage.html

380cb9b

Co-authored-by: gavin-ts <85081687+gavin-ts@users.noreply.github.com>

Code review fixes

3e50d87

Merge remote-tracking branch 'origin/d2-vscode-extension' into d2-vsc…

f1aa469

…ode-extension

BarryNolte and others added 6 commits January 11, 2023 19:49

d2-vscode-extension

a04006a

Added wrapper around displayed SVG tag to allow for zooming and fitting to screen.

Revert "d2-vscode-extension"

ba2e08f

This reverts commit 55049ca.

Revert "Revert "d2-vscode-extension""

518f8dd

This reverts commit d189451.

Added context menus and code cleanup

c7fcc3a

Added context menus everywhere it made sense and changed temp file deletion to be more deterministic.

Changes from Review

5dba3b0

Setup eslint and fixed errors and warnings. Made "fit" as the default on load Changed update timer code to be simpler Changed preview HTML to load from disk

BarryNolte closed this Jan 12, 2023

BarryNolte deleted the d2-vscode-extension branch January 13, 2023 01:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

d2-vscode-extension #11

d2-vscode-extension #11

BarryNolte commented Dec 4, 2022 •

edited

Loading

alixander commented Dec 5, 2022 •

edited

Loading

BarryNolte commented Dec 5, 2022

BarryNolte commented Dec 6, 2022

alixander commented Dec 6, 2022 •

edited

Loading

gavin-ts left a comment

BarryNolte commented Dec 23, 2022

gavin-ts left a comment

gavin-ts left a comment •

edited

Loading

gavin-ts left a comment

alixander commented Jan 11, 2023

BarryNolte commented Jan 11, 2023

alixander commented Jan 11, 2023

BarryNolte commented Jan 12, 2023

alixander commented Jan 12, 2023

BarryNolte commented Jan 12, 2023

alixander commented Jan 12, 2023

BarryNolte commented Jan 12, 2023

alixander commented Jan 12, 2023

BarryNolte commented Jan 12, 2023

d2-vscode-extension #11

d2-vscode-extension #11

Conversation

BarryNolte commented Dec 4, 2022 • edited Loading

alixander commented Dec 5, 2022 • edited Loading

BarryNolte commented Dec 5, 2022

BarryNolte commented Dec 6, 2022

alixander commented Dec 6, 2022 • edited Loading

gavin-ts left a comment

Choose a reason for hiding this comment

BarryNolte commented Dec 23, 2022

gavin-ts left a comment

Choose a reason for hiding this comment

gavin-ts left a comment • edited Loading

Choose a reason for hiding this comment

gavin-ts left a comment

Choose a reason for hiding this comment

alixander commented Jan 11, 2023

BarryNolte commented Jan 11, 2023

alixander commented Jan 11, 2023

BarryNolte commented Jan 12, 2023

alixander commented Jan 12, 2023

BarryNolte commented Jan 12, 2023

alixander commented Jan 12, 2023

BarryNolte commented Jan 12, 2023

alixander commented Jan 12, 2023

BarryNolte commented Jan 12, 2023

BarryNolte commented Dec 4, 2022 •

edited

Loading

alixander commented Dec 5, 2022 •

edited

Loading

alixander commented Dec 6, 2022 •

edited

Loading

gavin-ts left a comment •

edited

Loading