Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Watcher client favicon should be red on compile errors #10

Closed
alixander opened this issue Oct 19, 2022 · 5 comments
Closed

cli: Watcher client favicon should be red on compile errors #10

alixander opened this issue Oct 19, 2022 · 5 comments
Labels
cli This issue is related to the CLI (cmd/d2) good first issue Good for newcomers improvement Something can be better

Comments

@alixander
Copy link
Collaborator

alixander commented Oct 19, 2022 •
edited
Loading

like how github has (it's yellow here but it's red when there's an error)

Screen Shot 2023-01-02 at 1 45 55 PM
@alixander alixander added cli This issue is related to the CLI (cmd/d2) ready-for-work feature Something new improvement Something can be better and removed feature Something new labels Oct 19, 2022
@nhooyr nhooyr added this to D2 Oct 31, 2022
@alixander alixander added good first issue Good for newcomers and removed ready-for-work labels Jan 2, 2023
@sinyo-matu
Copy link
Contributor

Hi d2 authors.
I want to contribute to this issue.
And I am already done with my work.
You can check it at add favicon indicator.
Is it Ok to open a PR for this issue?

@alixander
Copy link
Collaborator Author

oh wow, please do! thanks @sinyo-matu

@sinyo-matu sinyo-matu mentioned this issue Apr 22, 2023
Merged
@sinyo-matu
Copy link
Contributor

@alixander Thanks!
Here it is #1240

@Nepo26
Copy link

Nepo26 commented Jun 24, 2023

Shouldn't this issue be closed @alixander as it was already merged?

@alixander
Copy link
Collaborator Author

good point!

@github-project-automation github-project-automation bot moved this to Done in D2 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli This issue is related to the CLI (cmd/d2) good first issue Good for newcomers improvement Something can be better
Projects
D2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alixander @sinyo-matu @Nepo26