Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add favicon error indicator #1240

Merged
merged 3 commits into from
May 7, 2023
Merged

add favicon error indicator #1240

merged 3 commits into from
May 7, 2023

Conversation

sinyo-matu
Copy link
Contributor

Fixing #10

  • add favicon.ico and favicon-err.ico to cli watch server resource.
  • add code to handle changing favicons depending on Websocket messages.

Here are some examples

  • without error
    image

  • with error
    image

@sinyo-matu sinyo-matu mentioned this pull request Apr 22, 2023
Closed
alixander
alixander requested changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @sinyo-matu !

would you mind signing your commits please? https://github.com/terrastruct/d2/blob/master/docs/CONTRIBUTING.md#logistics

d2cli/static/watch.js Outdated Show resolved Hide resolved
alixander
alixander requested changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment then good to go!

d2cli/watch.go Outdated Show resolved Hide resolved
alixander
alixander approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alixander alixander merged commit 6b9c4fa into terrastruct:master May 7, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinyo-matu @alixander