Terminal theme #1040
Merged
Terminal theme #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
force-pushed
the
terminal-theme
branch
from
c11c500
to
31ff195
Compare
alixander
force-pushed
the
terminal-theme
branch
from
31ff195
to
4c8c2b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introducing special theme rules, i.e. themes that change the diagram in more ways than just color.
still thinking about how best to apply those changes. i don't like that currently you need to pass in theme to two places (setDimensions and export). setDimensions because a theme may uppercase everything, which affects labels, and export b/c it affects attributes like border radius.