Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scenarios/steps inheritence #1090

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Mar 25, 2023

fixes a bug where scenarios and steps were not inheriting correctly.

we cannot compile scenarios after compiling the whole map.

we have to compile scenarios as we encounter them, so that further edits reference the inherited fields

Before

Screen Shot 2023-04-05 at 7 18 20 PM

After

Screen Shot 2023-04-05 at 7 11 11 PM

@alixander alixander requested a review from nhooyr April 6, 2023 00:03
@alixander alixander marked this pull request as ready for review April 6, 2023 00:03
@alixander alixander changed the title scenarios bug - edge index fix scenarios/steps inheritence Apr 6, 2023
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

d2ir/compile.go Outdated Show resolved Hide resolved
d2ir/compile.go Outdated Show resolved Hide resolved
@alixander alixander requested a review from nhooyr April 7, 2023 02:56
d2ir/compile.go Show resolved Hide resolved
@alixander alixander merged commit ad880fa into terrastruct:master Apr 7, 2023
@alixander alixander deleted the scenarios-bug branch April 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants