compiler: Compiler error when Link is set and Tooltip is an URL #1091
Conversation
|
Some |
There was a problem hiding this comment.
@alankan886 thank you! 🚀
The differing unrelated tests are due to computer architecture. I bet you're on x64 intel or some other AMD machine. These tests were generated on our ARM machines. Why is there a difference? TBD! #921
In the meantime, could you uncheck these from Git? Sorry for the trouble.
Lastly, could you sign your commits please? https://github.com/terrastruct/d2/blob/master/docs/CONTRIBUTING.md#logistics
|
Thanks for the quick review! I made the changes based on the comments, lmk if it's good! |
There was a problem hiding this comment.
@alankan886 can you squash your commits so that there's only the verified one? looks good other than that!
|
One second, looks like the unwanted changes are back again. |
# This is the 1st commit message: compiler: Compiler error when Link is set and Tooltip is an URL # The commit message terrastruct#2 will be skipped: # Update changelog
|
@alixander oh nooooo I was about to squash again, I was struggling a bit because I was so used to using squash and merge on Github rip |
|
hah appreciate that @alankan886 but no big deal =). it's a good point though i suppose i should wait for confirmation from the author after approving and before merging. will do next time. and welcome to the community! |
fixes: #888