-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layout with nested grids #1309
layout with nested grids #1309
Conversation
fcf4fb9
to
99b8c67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- i feel like
grid-gap
should apply to the padding? i'm thinking of this guy's use case: markdown: Tables #160 (comment) . or maybe nested grid just has 0 padding. (though nested container still does)
- do we still have to prevent edges when a grid cell is a container for a non-grid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- i feel like
grid-gap
should apply to the padding? i'm thinking of this guy's use case: markdown: Tables #160 (comment) . or maybe nested grid just has 0 padding. (though nested container still does)
- do we still have to prevent edges when a grid cell is a container for a non-grid?
I was thinking we could add container padding customization, but in its own PR. We will probably have to make labels have priority though, otherwise there's no place for them in nested containers with padding 0. The linked use case has labels and padding around each table. https://github.com/jfudickar/json2puml/blob/main/documentation/images/rocket/rocket_5e9d0d95eda69973a809d1ec.default.svg Is there a bug here with the order? is last supposed to be at the end? what's the d2?
currently yes, but I want to follow up with a refactoring of all of our different layout types (constant nears, sequence diagram, grid, + default) with this refactor, edges within a container in a grid cell would be fine as would a sequence diagram in a grid cell. |
no bug. was just demonstrating the padding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only lightly reviewed
Summary
Updating layout to support nested layouts within grids.
Details
new test