Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve grid performance with similarly sized objects #1315

Merged
merged 4 commits into from
May 10, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented May 10, 2023

Summary

If the object sizes don't vary much, we don't need to try as many threshold values.
If the fastLayout result is perfect, we don't need to search.

Details

  • adds grid_large_checkered test (which would previously timeout)
  • fixes performance issues in Feature Request: QR code #1302 leading to timeouts
  • refactor with constants
  • check standard deviation of sizes when determining how many threshold values to try
  • adds a skip limit, for if there are so many options even checking to skip them takes too long
  • improves debug logging

new test

Screen Shot 2023-05-09 at 6 11 19 PM

@gavin-ts gavin-ts requested a review from ejulio-ts May 10, 2023 01:23
@gavin-ts gavin-ts mentioned this pull request May 10, 2023
@gavin-ts gavin-ts merged commit c6820c8 into terrastruct:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants