Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust connections and labels for shapes with 3d or multiple #1340

Merged
merged 16 commits into from
May 27, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented May 24, 2023

Summary

Updates dagre and elk layouts to adjust connections and labels for shapes with 3d or multiple.

Details

multiple_offset before

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_multiple_offset_dagre_sketch exp svg

multiple_offset after

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_multiple_offset_dagre_sketch got svg

multiple_offset_left before/after

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (1)

e2ereport

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (2)

@gavin-ts gavin-ts marked this pull request as ready for review May 25, 2023 03:05
@gavin-ts gavin-ts requested a review from a team May 25, 2023 03:05
@gavin-ts gavin-ts changed the title Multiple offset adjust connections and labels for 3d or multiple May 25, 2023
@alixander alixander removed the request for review from a team May 25, 2023 21:29
@gavin-ts gavin-ts force-pushed the multiple-offset branch 2 times, most recently from ad56724 to 0a7f906 Compare May 26, 2023 00:03
@gavin-ts gavin-ts changed the title adjust connections and labels for 3d or multiple adjust connections and labels for shapes with 3d or multiple May 26, 2023
@gavin-ts gavin-ts requested review from alixander and a team May 26, 2023 02:22
d2graph/d2graph.go Show resolved Hide resolved
d2graph/d2graph.go Outdated Show resolved Hide resolved
d2graph/d2graph.go Outdated Show resolved Hide resolved
d2graph/d2graph.go Outdated Show resolved Hide resolved
lib/geo/point.go Show resolved Hide resolved
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2023-05-26 at 11 37 25 AM

while ur doing this, how hard would it be to add on adjusting for stroke width? if nontrivial, make another issue plz

@gavin-ts
Copy link
Contributor Author

while ur doing this, how hard would it be to add on adjusting for stroke width? if nontrivial, make another issue plz

created #1347 for this. haven't yet figured out why that is slightly off there, but stroke width should already be accounted for in the arrowhead adjustments

@gavin-ts gavin-ts requested a review from alixander May 27, 2023 03:20
@gavin-ts gavin-ts enabled auto-merge May 27, 2023 03:21
@gavin-ts gavin-ts merged commit 0332fe3 into terrastruct:master May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants