-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust connections and labels for shapes with 3d or multiple #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-ts
changed the title
Multiple offset
adjust connections and labels for 3d or multiple
May 25, 2023
gavin-ts
force-pushed
the
multiple-offset
branch
2 times, most recently
from
May 26, 2023 00:03
ad56724
to
0a7f906
Compare
gavin-ts
changed the title
adjust connections and labels for 3d or multiple
adjust connections and labels for shapes with 3d or multiple
May 26, 2023
alixander
requested changes
May 26, 2023
alixander
reviewed
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #1347 for this. haven't yet figured out why that is slightly off there, but stroke width should already be accounted for in the arrowhead adjustments |
alixander
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates dagre and elk layouts to adjust connections and labels for shapes with
3d
ormultiple
.Details
multiple
is set #63multiple_offset before
multiple_offset after
multiple_offset_left before/after
e2ereport