Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: transparent shape label mask #1383

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jun 8, 2023

Summary

Mask connections behind shape labels, subtly showing the connection transparently in the background.

Details

Screen Shot 2023-06-08 at 4 17 44 PM

before/after

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (5)

@gavin-ts gavin-ts requested a review from alixander June 9, 2023 00:26
@gavin-ts gavin-ts marked this pull request as ready for review June 9, 2023 00:26
@gavin-ts
Copy link
Contributor Author

gavin-ts commented Jun 9, 2023

Here's the 10% option:

Screen Shot 2023-06-08 at 5 33 14 PM

Previously 5%:

Screen Shot 2023-06-08 at 5 34 39 PM

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (6)

Screen Shot 2023-06-08 at 5 38 57 PM

@gavin-ts
Copy link
Contributor Author

gavin-ts commented Jun 9, 2023

Here's .15

Screen Shot 2023-06-08 at 7 08 24 PM
Screen Shot 2023-06-08 at 7 08 03 PM
Screen Shot 2023-06-08 at 7 08 39 PM

@gavin-ts
Copy link
Contributor Author

gavin-ts commented Jun 9, 2023

Ok here's the .25 option, good as a clearly visible but still transparent option

Screen Shot 2023-06-08 at 7 29 37 PM

@gavin-ts gavin-ts enabled auto-merge June 9, 2023 02:36
@gavin-ts gavin-ts merged commit f124ddf into terrastruct:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

low-opacity label masking on shape labels
2 participants