Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grid label font size in tala #1412

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix grid label font size in tala #1412

merged 2 commits into from
Jun 15, 2023

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes an issue where Object.Text will return the wrong font-size if called during grid-layout.

Details

  • grid object temporarily has Children removed during layout, causing isContainer to return false at that time
  • TALA reads this font-size to use during layout but it was giving the wrong result

TALA before/after

Screen Shot 2023-06-15 at 2 38 53 PM

@gavin-ts gavin-ts marked this pull request as ready for review June 15, 2023 21:43
@gavin-ts gavin-ts requested a review from a team June 15, 2023 21:43
@gavin-ts gavin-ts merged commit b843635 into terrastruct:master Jun 15, 2023
@Porkepix Porkepix mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavin-ts @alixander