Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null keyword #1446

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Null keyword #1446

merged 12 commits into from
Jun 27, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Jun 26, 2023 •
edited
Loading

only for objects and edges. no attribute nulling yet

partial of #735

@alixander alixander requested a review from nhooyr June 26, 2023 17:51
nhooyr
nhooyr suggested changes Jun 26, 2023
View reviewed changes
d2compiler/compile.go Outdated Show resolved Hide resolved
@alixander alixander requested a review from nhooyr June 26, 2023 18:58
@alixander alixander merged commit f7a83fa into terrastruct:master Jun 27, 2023
2 checks passed
@alixander alixander deleted the null branch June 27, 2023 20:44
nhooyr
nhooyr reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for comments
🔴

d2ir/d2ir.go Show resolved Hide resolved
d2ir/d2ir.go Show resolved Hide resolved
@alixander alixander mentioned this pull request Jul 3, 2023
Merged
@Porkepix Porkepix mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alixander @nhooyr