Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2ir: Single Level Ampersand Filters #1509

Merged
merged 23 commits into from
Jul 30, 2023
Merged

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 29, 2023

Depends on #1479 being merged.

I didn't implement recursive filters in this PR. i.e you can't do something like:

*: {
  &style: {
    fill: red
    multiple: true
  }
  label: red and multiple
}

You have to do the following instead:

*: {
  style: {
    &fill: red
    &multiple: true
  }
  label: red and multiple
}

@nhooyr nhooyr requested a review from alixander July 29, 2023 23:35
@nhooyr nhooyr force-pushed the filters branch 3 times, most recently from 710c46e to eb6aa52 Compare July 29, 2023 23:55
@nhooyr
Copy link
Contributor Author

nhooyr commented Jul 30, 2023

In fact I don't think we want to have composite filters anyhow. I think single field filters are easier to read and much easier to implement. For example for composite filters we'd have to error if the filter itself had ampersand filters because that wouldn't make sense.

@nhooyr nhooyr enabled auto-merge July 30, 2023 00:16
@nhooyr nhooyr force-pushed the filters branch 2 times, most recently from be59fa5 to e85d9e8 Compare July 30, 2023 08:16
Were identified from @alixander writing documentation.
d2ir/compile.go Show resolved Hide resolved
d2ir/compile.go Outdated Show resolved Hide resolved
@nhooyr nhooyr disabled auto-merge July 30, 2023 20:47
@nhooyr nhooyr merged commit a1a2245 into terrastruct:master Jul 30, 2023
2 checks passed
@nhooyr nhooyr deleted the filters branch July 30, 2023 20:50
@bo-ku-ra bo-ku-ra mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants