fix(cli): do not exit after 1st formatted file #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
requested changes
Aug 2, 2023
There was a problem hiding this comment.
good catch, thanks!
we should also accept directories, made this issue: #1526
can you add a test in https://github.com/terrastruct/d2/blob/master/e2etests-cli/main_test.go ?
i've just added a basic fmt test that you can follow as example: #1527
Awesome, exactly what I was looking for, thank you! |
maxbrunet
force-pushed
the
fix/fmt/format-all
branch
from
a4caac4
to
b560e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
Thank you so much for
d2, loving it so far!Found a small bug in
d2 fmt: If ran on multiple non-formatted files at once, it would format the 1st and exit, leaving the others non-formatted.