Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: allow current color as valid css color #1700

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

hboomsma
Copy link
Contributor

@hboomsma hboomsma commented Nov 3, 2023

In SVG images curentColor is allowed as a way to explicitly inherit the current color. When setting currentColor as fill color on a shape together with a styling class, the class will now be used instead of the theme, which was not possible otherwise. This way you can put theme classes on shapes making them respond to dark mode. This is most useful in combination with custom themes.

In SVG images `curentColor` is allowed as a way to explicitly inherit the current color. When setting `currentColor` as fill color on a shape together with a styling class, the class will now be used instead of the theme, which was not possible otherwise.
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @hboomsma !

@alixander alixander merged commit f3c5909 into terrastruct:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants