Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom label positions for grid containers #1715

Merged
merged 9 commits into from
Nov 9, 2023
Merged

custom label positions for grid containers #1715

merged 9 commits into from
Nov 9, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Nov 9, 2023 •
edited
Loading

Summary

Allow grid containers to have custom label positions.

Details

before

Screenshot 2023-11-08 at 4 21 47 PM

after

Screenshot 2023-11-08 at 4 21 40 PM

@gavin-ts gavin-ts marked this pull request as ready for review November 9, 2023 04:38
alixander
alixander approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@gavin-ts gavin-ts merged commit 903313d into terrastruct:master Nov 9, 2023
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grid: support custom label/icon positions for grid containers
2 participants
@gavin-ts @alixander