Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: watch imported files #1720

Merged
merged 5 commits into from
Nov 16, 2023
Merged

cli: watch imported files #1720

merged 5 commits into from
Nov 16, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Nov 10, 2023 •
edited
Loading

closes #1521

also closes #1508

@alixander alixander force-pushed the watch-imports branch 2 times, most recently from cd30bd5 to 3a78561 Compare November 10, 2023 19:13
@alixander
Copy link
Collaborator Author

@nhooyr I touched a part of the code where you left a comment not to touch w/o consulting you (3a78561)

No expectations to review, just respecting the wishes. I can also remove the comment now if you'd like.

@alixander alixander marked this pull request as ready for review November 10, 2023 19:38
@alixander alixander merged commit 97cbc62 into terrastruct:master Nov 16, 2023
3 checks passed
@alixander alixander deleted the watch-imports branch November 16, 2023 05:43
@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landmaj landmaj landmaj left review comments

@gavin-ts gavin-ts gavin-ts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Live reload doesn't react to changes in imported files potential race with boardPath in watch mode
3 participants
@alixander @landmaj @gavin-ts