always allow width/height on grid containers

[gavin-ts]

Summary

Allow setting width/height on grid containers even when the layout plugin doesn't have that feature.

Details

• fixes dagre: dimensions on grid containers #1722
• adds grid_container_dimensions test
• before e2e_test.go:203: unexpected error: Object "grid" has attribute "width" and/or "height" set, but layout engine "dagre" does not support dimensions set on containers. See https://d2lang.com/tour/layouts/#layout-specific-functionality for more.
• updates grid layout to size according to width/height and center contents accordingly

grid container with width: 200; height: 200

[alixander]

wait, why doesn't the grid cells expand? this feature should not exist as is, my mistake to approve without checking. this is completely wrong/unexpected behavior, as if it were creating a new container

[gavin-ts]

wait, why doesn't the grid cells expand? this feature should not exist as is, my mistake to approve without checking. this is completely wrong/unexpected behavior, as if it were creating a new container

oh interesting, didn't realize that was what #1722 wanted

[gavin-ts]

so to confirm, the idea is any extra space (not including gap) set on the grid container will be divided among the cells, expanding the cells too?

[gavin-ts]

this is completely wrong/unexpected behavior, as if it were creating a new container

hmm but it is a container, it is just hidden when there is grid-gap: 0 and an outside label and rectangular non-transparent cells.

[gavin-ts]

hmm, I think scaling the cells should be done on the cells itself, and the grid container's size is independent

E.g. If you have a hexagon grid container, and want to increase the height, I would expect this change from left hexagon to right, and I wouldn't expect it to stretch the cells.

[alixander]

I see what you're saying about it being a container. That's right, my bad.

Anyway, so the decision is just whether to stretch the grid cells.

I think the motivation for me is just I can't imagine a case where one would want to adjust sizing without stretching grid cells. Like you only would want to specify grid dimensions if your intention is to control how big or small the cells look in the diagram.

[gavin-ts]

a case where one would want to adjust sizing without stretching grid cells.

One example: Let's say you have this diagram and want to make the hexagon the same height as the circle

I think the result should be:

Rather than:

Unless you specify that explicitly.

Alternatively, this is the starting state (which also seems unexpected to me):

but then they are (mostly) even when you size the hexagon:

What behavior do you think this example should have?

vars: {
  grid-container: {
    label: ""
    grid-gap: 10
    grid-rows: 1
    grid-columns: 4
    a
    b
    c
    d
  }
}

circle: {
  shape: circle
  ...${grid-container}
  width: 395
}

hexagon: {
  shape: hexagon
  ...${grid-container}
  # width: 395
  # height: 395
}

direction: right
circle -> hexagon

Update: this also means different shapes would stretch the same cells different amounts at same dimensions

vs

maybe this behavior can be a setting e.g. grid-fill: true, fill-grid: true, or stretch-grid: true?