Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cloud shape has multiple inner boxes to use depending on the aspect ratio of the content, but
getInnerBox
was selecting which one with its own aspect ratio instead of the aspect ratio of its content.This updates the cloud shape so that
getInnerBox
returns the correct one.Details
getInnerBox
to usebefore/after
shaped_grid_position cloud before/after
with old bounding box + incorrect positioning
with new bounding box + correct positioning
contentAspectRatio is now saved for cloud shapes
e2ereport
the 3 different innerBoxes for reference