fix edge glob bug #1857
Merged
fix edge glob bug #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
force-pushed
the
delete-connection-glob
branch
from
b1178cb
to
9144aec
Compare
alixander
commented
Mar 7, 2024
| @@ -1094,7 +1094,7 @@ func (m *Map) getEdges(eid *EdgeID, refctx *RefContext, gctx *globContext, ea *[ | |||
| } | |||
| gctx.appliedEdges[ks] = struct{}{} | |||
| } | |||
| *ea = append(*ea, ea2...) | |||
| *ea = append(*ea, e) | |||
There was a problem hiding this comment.
this bug was causing globs to be applied multiple times
alixander
commented
Mar 7, 2024
| @@ -413,6 +413,7 @@ func (c *compiler) ampersandFilterMap(dst *Map, ast, scopeAST *d2ast.Map) bool { | |||
| ks = d2format.Format(d2ast.MakeKeyPath(BoardIDA(dst))) | |||
| } | |||
| delete(gctx.appliedFields, ks) | |||
| delete(gctx.appliedEdges, ks) | |||
There was a problem hiding this comment.
this bug was causing filters on edges to not try to be applied again. which only surfaced because the other bug was fixed that errantly applied multiple times
alixander
force-pushed
the
delete-connection-glob
branch
from
2b9d2da
to
453c243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes some d2oracle functions when globs are present
also upgrades go version 1.20 -> 1.22