fix: makes bidirectional animations correct #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsuh05
changed the title
Signed-off-by: Daniel Suh <23denial@gmail.com>
alixander
requested changes
May 17, 2024
There was a problem hiding this comment.
the tests outputs look great! Can you please add to next.md as well?
Also I'm not sure if you want to implement this for the sketch renderer (d2renderers/d2sketch) as well. I don't know what it entails, you're welcome to take a look or just open another issue after this.
|
I'll create an issue for the sketch renderer soon, I'll take a look at how much work it is and decide if I want to tackle it. Thanks for all the comments! |
alixander
requested changes
May 18, 2024
alixander
requested changes
May 18, 2024
alixander
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1936, #654
Screen.Recording.2024-05-14.at.16.20.43.mov
Makes <-> and -- have correct animation. I edit the path string instead of the points due to the rounded corners becoming sharp when using S curves (if you have a path from b -> a and b -> c, it is not trivial to round the corner b). Bezier curve segmentation is not perfect due to the parameterization of a bezier curve being inaccurate, but is good enough.