render: use style.font-size attribute #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-ts
force-pushed
the
support-all-font-sizes-in-range
branch
3 times, most recently
from
92f27f4
to
56331b1
Compare
alixander
requested changes
Nov 30, 2022
ejulio-ts
reviewed
Nov 30, 2022
ejulio-ts
approved these changes
Nov 30, 2022
gavin-ts
force-pushed
the
support-all-font-sizes-in-range
branch
from
6ddadc5
to
2f96210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Render shape and connection labels with the font size specified in the
style.font-sizeattribute.Update text measurement to support loading a new font size on demand.
Previously the font-size attribute would be ignored on shapes, and would always be measured at the default 16 for connections.
Details
font_sizestests with various font sizesstyle.font-sizebefore
after
font_sizes test (dagre)
todo test related to #19