sketch: fix regex typo in rough.js #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
requested changes
Dec 30, 2022
There was a problem hiding this comment.
wow, nice, how did you find this?
can you run ci? https://github.com/terrastruct/d2/blob/master/docs/CONTRIBUTING.md#ci
Just fetch the CI submodule and run ./make.sh
When I looked into the library to try solving issue #533, I noticed the difference :) |
alixander
requested changes
Dec 30, 2022
alixander
approved these changes
Dec 30, 2022
|
@nekikara sorry just one more hoop, it's a one-time thing with having signed commits: |
|
close by #569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for an incredible diagram scripting tool.
I found the regex is different from that in rough-stuff/rough.