-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render: fix sketch arrowheads #656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-ts
force-pushed
the
fix-sketch-arrowheads
branch
2 times, most recently
from
January 13, 2023 03:57
b5b6f11
to
3feedda
Compare
<-> and triangle arrow is the same style? i think the <-> can look more "arrow-y" i think “crows foot one” is a lil weird. circle can be a tad bigger (to match crows foot many) and the line can be more in the middle of the circle and the edge |
|
but yeah i think the example is confusing, since <-> is default triangle, it's covered twice |
gavin-ts
force-pushed
the
fix-sketch-arrowheads
branch
from
January 14, 2023 02:17
3ae1d81
to
b49fbc7
Compare
alixander
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sketch arrowheads sometimes appearing broken, and render them in a sketched style.
Details
new arrowheads test before
after rendering arrowheads separately
after rendering sketch specific arrowheads (final)