Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to see if command exists with POSIX 'command' #693

Merged
merged 6 commits into from
Feb 10, 2023

Conversation

exapsy
Copy link
Contributor

@exapsy exapsy commented Jan 20, 2023

Continuation from unverified/unsigned commits on #690

@alixander alixander requested a review from nhooyr January 20, 2023 01:13
ci/e2ereport.sh Outdated Show resolved Hide resolved
Co-authored-by: Anmol Sethi <hi@nhooyr.io>
@exapsy exapsy requested a review from nhooyr January 20, 2023 12:38
ci/e2ereport.sh Outdated Show resolved Hide resolved
@exapsy exapsy requested a review from nhooyr January 21, 2023 17:01
Signed-off-by: Apostolis Anastasiou <apostolis.anastasiou.alpha@gmail.com>
ci/e2ereport.sh Outdated Show resolved Hide resolved
Co-authored-by: Anmol Sethi <hi@nhooyr.io>
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for all the little change requests haha

ci/e2ereport.sh Outdated Show resolved Hide resolved
ci/e2ereport.sh Outdated Show resolved Hide resolved
@nhooyr nhooyr enabled auto-merge February 10, 2023 04:09
@nhooyr
Copy link
Contributor

nhooyr commented Feb 10, 2023

Thank you @exapsy 🚀

@alixander
Copy link
Collaborator

looks like you still have to approve @nhooyr

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhooyr nhooyr merged commit 45e4d25 into terrastruct:master Feb 10, 2023
@exapsy
Copy link
Contributor Author

exapsy commented May 31, 2023

@alixander im so sorry for not looking at the requests. Just took a glance at my email feed and saw this github issue and I immediately had a flashback. My apologies, thanks for accepting my contribution:)

@exapsy exapsy deleted the add-xdgopen-on-make-script branch May 31, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants